-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert "Permieres on" UTC time to local time #1429
Convert "Permieres on" UTC time to local time #1429
Comments
@PrestonN Any update on this issue? It seems to of been incorrectly labelled as an enhancement instead of a bug |
I use Freetube v0.16.0 on Arch Linux and currently use CEST time. While i say premiere time is reported correctly, it's displayed in the mm/dd/yyyy format with a 12 hour clock, I don't use this format at all. |
Good question, I haven't tested this for a while and also haven't looked at any streams. I'll report back here if I can confirm or deny that this is still an issue |
@Aiz0 The date format is probably hard-coded, probably best to open an issue for supporting |
After setting ALL locale variables it seems to be using correct date format, yyyy-mm-dd with 24 hour clock. Freetube uses the toLocaleString() to return the premier date as a string with locale settings. Firefox seems to behave the same. It's very weird. |
Yep, this is still an issue in FreeTube v0.16.
But, https://youtu.be/_BDClzHu-ho says it starts at |
Could this issue be related to Flathub/flatpak then? I've found this disscussion regarding another flathub app. From the discussion this was a temporary solution so try launching freetube like this If you still use flatpak |
For some reason, the FreeTube Flatpak manually sets No other Flatpak I have installed sets EDIT: Nevermind, the video release times are still one hour behind even after removing |
@efb4f5ff-1298-471a-8973-3d47447115dc Any chance you could comment on this? |
I looked into this again and removing The reason it was added seems to be because of a crash if the time zone was unknown. running I suppose the workaround is no longer required in later versions of electron. @Winterhuman could you try removing |
There's a build on the testing repository now: https://buildbot.flathub.org/#/builders/32/builds/110792
|
I'll check next time I find a stream premiere |
Open this in browser and you should be able to find some upcoming live streams. |
Regardless of EDIT: Turns out I have to set |
Just to be clear. Does the build I linked use the correct timezone without you having to make any modifications to the environment? When you say you are removing I have not tested this with flatseal but instead made a build without the line.
remove line 16
The build linked contains the same modifications and both work on my end. |
Yes, your build does show the correct time |
@Aiz0 u have fixed this issue right? |
As far as I know this should only be an issue on flatpak builds. |
Okay then ill close it because there is a separate repo for flatpak |
Currently "Premieres on" seems to be using UTC time instead of local time. I live in UTC+02:00 so a stream or video premier starting at 19:00:00 local time will be reported as starting on 17:00:00 UTC.
Could someone knowledgeable with the codebase confirm that this is indeed what FreeTube is doing? I am just guessing here as to what this behavior is caused by.
The text was updated successfully, but these errors were encountered: