Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timezone workaround #78

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Remove timezone workaround #78

merged 2 commits into from
Aug 21, 2023

Conversation

Aiz0
Copy link
Contributor

@Aiz0 Aiz0 commented Sep 16, 2022

Removing this will make FreeTube use the users timezone instead of defaulting to UTC.

closes FreeTubeApp/FreeTube#1429

This workaround was added in 279265a to prevent a crash.

I've tested and even using --env=TZ=ETC/Unknown does not cause any crashes.
running Intl.DateTimeFormat().resolvedOptions().timeZone returned Undefined
and new Date().ToLocaleString() returned '16/09/2022'

I've not experianced any crashes with an unknown timezone.
Freetube should now be able to use the users timezone.
@flathubbot
Copy link

Started test build 110792

@flathubbot
Copy link

Build 110792 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/108415/io.freetubeapp.FreeTube.flatpakref

@flathubbot
Copy link

Started test build 59941

@flathubbot
Copy link

Build 59941 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42579/io.freetubeapp.FreeTube.flatpakref

@PrestonN
Copy link
Collaborator

LGTM

@PrestonN PrestonN merged commit fc90f5a into flathub:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert "Permieres on" UTC time to local time
3 participants