Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding keywords in PR template in order to link an issue #1512

Closed
1 of 5 tasks
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jul 11, 2021 · 2 comments · Fixed by #1687
Closed
1 of 5 tasks

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Topic
Please select what topic your discussion is about.

  • Coding
  • Contribution
  • Languages
  • Setup
  • Other. Please specify:

Discussion
In the PR template in the "Relate issue" section, contributes often add this issue number. However they forget to use the keywords in order to close the related issue. If this doesn't happen the PR gets merged but issue will stay open and clutter the backlog.

I think its better to add a few keywords (or just one) to the PR template, so u guys wont have to cleanup the backlog.

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

An important question to ask is what do we do with PR's that make changes related to an issue but immediately not solve it? Just not link it? So the issue stay open until its actually solved by another PR.

@jasonhenriquez
Copy link
Collaborator

An important question to ask is what do we do with PR's that make changes related to an issue but immediately not solve it? Just not link it? So the issue stay open until its actually solved by another PR.

I think this distinction should just be clarified in the PR template. Something to the effect of: 'If this pull request fully resolves the relevant issue, put "closes" before the issue number. Example: "closes #99999"'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants