New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to yaml issue templates (forms) #1593
Switch to yaml issue templates (forms) #1593
Conversation
I think more discussion needs to be done on whether this should be implemented or not |
Looking at a glance, I do like this. I wasn't aware GitHub had something like this. This should help quite a bit with getting the information we need for submissions. |
Ah i was searching for this some time ago because i saw that the element repo used this. But i forgot about it again, this would be really nice to implement. Maybe say this "This bug persist in the latest nightly build" instead of saying "im using the latest version" Example: #1595 this issue was created without checking the nightly because this was already resolved in the nightlys. |
Maybe the forms can also be used for the PR's |
From what I can tell, PR templates don't support the yaml format & I have not seen any projects using it for PR Templates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and just to make sure, I checked out your repo as well to see it in action. I would like @PrestonN 's confirmation for this but this looks all good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few suggestions & considerations (also: fix the indents)
@peepopoggers this PR is still a WIP because i still need to add labels for the feature request template. |
was uninformed :) hope this sees progress as yaml forms look nice |
My suggestions for feature request labels, in no particular order:
|
Anything else we're waiting on for this PR before considering its approval? |
i think everything is addressed and it is ready to be merged! I think that its safe for me to approve this PR myself if two other reviewers approve first. Let me know if u dont prefer me approving the PR as third reviewer |
I think we should let @PrestonN have a final review before merge |
Is there any reason why this should not be merged? |
No i think u can approve it but the third reviewer spot is reserved for @PrestonN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go ahead and approve this. There may be some more tweaks for it in the future, but it's leagues better than how everything is setup currently. We can change more to it down the line when needed.
Thanks so much for putting this together!
Switch to yaml issue templates (forms)
Important note
Please note that only PrestoN is able to merge Pull Requests into master.
Pull Request Type
Please select what type of pull request this is:
Related issue
closes #1541
Description
This PR will disable blank issues & require issues to follow the template
To preview:
https://github.com/ChunkyProgrammer/github-issue-form-test/issues/new/choose
if ^ link outdated try
https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/github-issue-form-test/issues/new/choose
Screenshots (if appropriate)
(red star indicated required)
Bug Report
Feature Request
Discussions (Might be removed in favour of discussions tab)
Questions (Might be removed in favour of discussions tab)
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Please describe shortly how you tested it and whether there are any ramifications remaining.
I tested this PR by creating issues on this repo
https://github.com/ChunkyProgrammer/github-issue-form-test
if ^ link outdated try
https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/github-issue-form-test/issues/new/choose
Desktop (please complete the following information):