Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to yaml issue templates (forms) #1593

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Aug 17, 2021


Switch to yaml issue templates (forms)

Important note
Please note that only PrestoN is able to merge Pull Requests into master.

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation

Related issue
closes #1541

Description
This PR will disable blank issues & require issues to follow the template

To preview:
https://github.com/ChunkyProgrammer/github-issue-form-test/issues/new/choose

if ^ link outdated try
https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/github-issue-form-test/issues/new/choose

Screenshots (if appropriate)
(red star indicated required)
Bug Report
image

Feature Request
image

Discussions (Might be removed in favour of discussions tab)
image

Questions (Might be removed in favour of discussions tab)
image

Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Please describe shortly how you tested it and whether there are any ramifications remaining.
I tested this PR by creating issues on this repo
https://github.com/ChunkyProgrammer/github-issue-form-test

if ^ link outdated try
https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/github-issue-form-test/issues/new/choose

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.13.2

@ChunkyProgrammer
Copy link
Member Author

I think more discussion needs to be done on whether this should be implemented or not

@PrestonN
Copy link
Member

Looking at a glance, I do like this. I wasn't aware GitHub had something like this. This should help quite a bit with getting the information we need for submissions.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Ah i was searching for this some time ago because i saw that the element repo used this. But i forgot about it again, this would be really nice to implement.

Maybe say this "This bug persist in the latest nightly build" instead of saying "im using the latest version"

Example: #1595 this issue was created without checking the nightly because this was already resolved in the nightlys.

@efb4f5ff-1298-471a-8973-3d47447115dc

Maybe the forms can also be used for the PR's

#1512

@ChunkyProgrammer
Copy link
Member Author

Maybe the forms can also be used for the PR's

#1512

From what I can tell, PR templates don't support the yaml format & I have not seen any projects using it for PR Templates
"Pull request template filenames are not case sensitive, and can have an extension such as .md or .txt."

peepo5
peepo5 previously approved these changes Sep 16, 2021
Copy link
Contributor

@peepo5 peepo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and just to make sure, I checked out your repo as well to see it in action. I would like @PrestonN 's confirmation for this but this looks all good.

Copy link
Member Author

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions & considerations (also: fix the indents)

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
@peepo5 peepo5 added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: WIP labels Oct 7, 2021
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: WIP PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 7, 2021
@efb4f5ff-1298-471a-8973-3d47447115dc

@peepopoggers this PR is still a WIP because i still need to add labels for the feature request template.

@peepo5
Copy link
Contributor

peepo5 commented Oct 7, 2021

was uninformed :) hope this sees progress as yaml forms look nice

@jasonhenriquez
Copy link
Collaborator

My suggestions for feature request labels, in no particular order:

  • improvement to existing feature
  • new optional setting
  • visual improvement
  • display more information to user
  • ease of use improvement
  • support for external software
  • new keyboard shortcut

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: WIP labels Oct 15, 2021
@jasonhenriquez
Copy link
Collaborator

Anything else we're waiting on for this PR before considering its approval?

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

i think everything is addressed and it is ready to be merged!

I think that its safe for me to approve this PR myself if two other reviewers approve first.

Let me know if u dont prefer me approving the PR as third reviewer

@PikachuEXE
Copy link
Collaborator

I think we should let @PrestonN have a final review before merge

@peepo5
Copy link
Contributor

peepo5 commented Jan 7, 2022

Is there any reason why this should not be merged?

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

No i think u can approve it but the third reviewer spot is reserved for @PrestonN

Copy link
Member

@PrestonN PrestonN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and approve this. There may be some more tweaks for it in the future, but it's leagues better than how everything is setup currently. We can change more to it down the line when needed.

Thanks so much for putting this together!

@PrestonN PrestonN disabled auto-merge January 8, 2022 03:34
@PrestonN PrestonN merged commit 6d32bd0 into FreeTubeApp:development Jan 8, 2022
@ChunkyProgrammer ChunkyProgrammer deleted the switch-to-yaml-issue-templates branch February 2, 2022 00:40
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributes that open an issue but don't follow the provided template
6 participants