Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird alignment of video information sections when the setting "Hide Recommended Videos" is enabled. #909

Closed
Aiz0 opened this issue Jan 1, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Aiz0
Copy link
Contributor

Aiz0 commented Jan 1, 2021

Behavior of the program
When the "Hide Recommended Videos" setting in "Distraction Free settings" is enabled there is a lot of empty space below the video to the right where the recommended videos used to be. Despite this empty space being there, the video info section, video description section, and comments section are offset to the left as if the recommended videos section is still there. This make the interface look a little awkward in my opinion.

Expected behavior
When "Hide Recommended Videos is enabled" the video info section, video description section, and comments section should be aligned with the video and be at least as wide as the video. This would remove a lot of empty space and make it look a bit nicer.

To Reproduce

  1. Go to settings.
  2. Scroll down to "Distraction Free Settings".
  3. Enable "Hide Recommended Videos".
  4. Click on a video. It should be in "theatre mode".
  5. Scroll down to the comments section
  6. The video information sections are aligned as if the recommended videos section was still there, even though it's not.

Screenshots
Here is a screenshot of what it currently looks like. When the recommended videos section isn't there the interface looks awkward
screenshot of video

Environment Information:

  • OS: Arch Linux
  • OS Version: Kernel 5.10.3-arch1-1
  • FreeTube version: v0.10.0 Beta
  • Primary API Used: Local API

Additional context
When viewing a live stream in "theatre" mode the live chat takes up the place where the recommended videos section usually is. Because of that it should not be necessary for any changes to the interface when viewing a live stream with live chat.

@Aiz0 Aiz0 added the bug Something isn't working label Jan 1, 2021
@cloudrac3r
Copy link
Collaborator

Also working on a patch for this.

cloudrac3r added a commit to cloudrac3r/FreeTube that referenced this issue Jan 9, 2021
cloudrac3r added a commit to cloudrac3r/FreeTube that referenced this issue Jan 9, 2021
If there's nothing to display in the sidebar according to the
distraction settings and live status, the watch page will adopt a
single column layout. If the sidebar still exists due to faulty logic,
it will be placed at the very bottom of the page.

Most likely closes: FreeTubeApp#909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants