Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live chat can't be displayed next to video when the setting "Hide Recommended Videos" is enabled. #910

Closed
Aiz0 opened this issue Jan 1, 2021 · 2 comments
Closed

Live chat can't be displayed next to video when the setting "Hide Recommended Videos" is enabled. #910

Aiz0 opened this issue Jan 1, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Aiz0
Copy link
Contributor

Aiz0 commented Jan 1, 2021

Behavior of the program
When the setting "Hide Recommended Videos" is enabled you can't disable "theatre mode". This becomes a problem when you want to view a live stream with live chat. When "theatre mode" is off, the livechat is displayed right next to the video so that you can view the video and the live chat at the same time. When "theatre mode" is on, the top of live chat is barely visible because it's pushed down next to the video information section. In "theatre mode" you can't view the video and the live chat at the same time on a 1080p 16:9 screen. When the setting "Hide Recommended Videos" is enabled it forces "theatre mode" to always be on. This means you can't view a live stream with the live chat next to it.

Expected behavior
When viewing a live stream I also want to view the live chat. This means the button to toggle "theatre mode" should be available when viewing a live stream with live chat even when the setting "Hide Recommended Videos" is enabled.

To Reproduce
Please add all steps to reproduce the behavior:

  1. Go to settings.
  2. Scroll down to "Distraction Free Settings".
  3. Enable "Hide Recommended Videos".
  4. Click on a live stream with live chat. A 24/7 lofi stream for example.
  5. You should see that the button to toggle "theatre mode" is not available.

Screenshots
Here is what it currently looks like.
screenshot

Environment Information:

  • OS: Arch Linux
  • OS Version: Kernel 5.10.3-arch1-1
  • FreeTube version: v0.10.0 Beta
  • Primary API Used: Local API
@Aiz0 Aiz0 added the bug Something isn't working label Jan 1, 2021
@GilgusMaximus
Copy link
Contributor

Thanks for sharing these layout bugs. They are usually hard to spot for us when we ourselves do not use these features. The way the layout works definitely requires an update to fix these issues

@cloudrac3r
Copy link
Collaborator

Working on a patch for this.

cloudrac3r added a commit to cloudrac3r/FreeTube that referenced this issue Jan 9, 2021
@cloudrac3r
Correctly lock theatre mode switch
2c290d6 
Most likely closes: FreeTubeApp#910
cloudrac3r added a commit to cloudrac3r/FreeTube that referenced this issue Jan 9, 2021
@cloudrac3r
Correctly bind theatre mode options
911e80e 
Theatre mode is now bound to both "recommended videos" and "live chat"
distraction settings, rather than just "recommended videos".

The settings switch, the button, and the layout have all been updated
to reflect this.

Most likely closes: FreeTubeApp#910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cloudrac3r @GilgusMaximus @Aiz0