Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of youtube link middle mouse click #2083

Merged
merged 1 commit into from
May 30, 2022
Merged

Fix handling of youtube link middle mouse click #2083

merged 1 commit into from
May 30, 2022

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Feb 16, 2022 •
edited
Loading

Pull Request Type
Please select what type of pull request this is:

  • Bugfix

Related issue
#1809

Description
2be2301 only fixes the issue partially so that any click results in opening in current window
But the expected behaviour is to open links clicked by middle mouse button in new window

Screenshots (if appropriate)

Screen.Recording.2022-02-16.at.14.47.03.mov

Testing (for code that is not small enough to be easily understandable)

Desktop (please complete the following information):

  • OS: MacOS
  • OS Version: 12.1
  • FreeTube version: 7a4b600

Additional context
Too busy, only tested with video URL
Add back more test cases later

@PrestonN PrestonN enabled auto-merge (squash) February 16, 2022 06:49
@PikachuEXE PikachuEXE mentioned this pull request Feb 16, 2022
Merged
2 tasks
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 16, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PikachuEXE PikachuEXE force-pushed the fix/comment-yt-url-handling branch from ad3ec3f to e4b7c9b Compare May 12, 2022 03:12
@PikachuEXE
Copy link
Collaborator Author

@efb4f5ff-1298-471a-8973-3d47447115dc
Just did a rebase and solve one merge conflict
about adding a new function in src/renderer/App.js, #1800 added one there too
Should have no issue and I think this fix should be include in next release (if really no issue found)

Closed
3 tasks
@PikachuEXE PikachuEXE force-pushed the fix/comment-yt-url-handling branch from e4b7c9b to 6126683 Compare May 19, 2022 03:19
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@PikachuEXE it sometimes flickers when i open a new tab like this

VirtualBoxVM_SNgXaKVuDx.mp4

@PikachuEXE
Copy link
Collaborator Author

I am not sure how to reproduce that.
Is it only reproducible on this branch?
What are the error messages? (Not the warnings)

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

0 errors -.-
And as far as i know i only get it in this branch

@PikachuEXE
Copy link
Collaborator Author

If you launch via npm run dev/debug I think it's better to also try built app
Grab one at https://github.com/PikachuEXE/FreeTube/actions/workflows/build.yml
I use my own build all the time to test my own changes

image

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes May 24, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur build works like a charm!

@PikachuEXE PikachuEXE requested a review from absidue May 25, 2022 01:36
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@ChunkyProgrammer help this Pikachu out

@PrestonN PrestonN merged commit 2db528b into FreeTubeApp:development May 30, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 30, 2022
@PikachuEXE PikachuEXE deleted the fix/comment-yt-url-handling branch May 31, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@PrestonN PrestonN Awaiting requested review from PrestonN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @ChunkyProgrammer @PrestonN