Sync theme between windows #2090
Conversation
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
|
So if i understand correctly this one needs to be merged first in order to get #1800 merged right? |
Yes, this will make my other PR simpler to debug. :) |
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
ChunkyProgrammer
|
@efb4f5ff-1298-471a-8973-3d47447115dc |
|
everything works like intended. The only thing that is bugging me is this #1800 (comment) but i guess that ur answer would be the same as last time #1800 (comment). If that the case, i'll approve after ur response |
Is that issue you were facing in #1800 happening with this PR also? If it is not I hope we can merge this in and we test the other PR with these changes once I debug a bit more there. Thanks for your help! |
|
Not sure if we're talking about the same issue. U can see the issue im facing in the video that is linked in the comment |
Ah I see now, I did misunderstand yeah. That issue should no longer be an issue with the database changes that were brought in a bit back, I'll take a look at it when I'm working on the PR again and make sure I fix it (if it still exists) since I agree it's not nice :) |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
Just to be clear @efb4f5ff-1298-471a-8973-3d47447115dc I don't think any changes are needed on this PR, I meant when I return to work on the next one. Are there any changes outside of that? |
|
Outside of that? No. I'll approve the pr! |
|
We should probably also remove the changes requested label so Chunky knows they can review this 😉 |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
removed
the
PR: waiting for review
Sync theme between windows
Pull Request Type
Related issue
N/A
Description
Finally moves baseTheme, mainColor, secColor logic away from localstorage and into vuex so that we can seamlessly sync them between windows and lower code overhead. It also syncs the expandSideBar setting between windows.
Screenshots (if appropriate)
N/A
Testing (for code that is not small enough to be easily understandable)
Open several windows and flip between themes to your hearts content.
Desktop (please complete the following information):
Additional context
This will help merge #1800 as there is an issue there with themes resetting and not syncing properly. Since this cleans up the logic it will make it easier to debug that.