Prevent search input reset from overwriting clipboard on Linux #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 12, 2022
PikachuEXE
approved these changes
May 13, 2022
github-actions
bot
removed
the
PR: waiting for review
|
Thank you so much for this. I've built (the (Thank you also for not just dismissing the issue as "works for me" or "user error".) |
|
There are so many platforms and no way we can be sure things work for all platforms well. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent search input reset from overwriting clipboard on Linux
Pull Request Type
Related issue
Closes #2019
Description
Removes the input event emitter in favour of a more standard way of clearing an input field to prevent clipboards being overwritten.
Testing (for code that is not small enough to be easily understandable)
Test with any form of selection-based clipboards (middle mouse button on most Linux systems). Select any text, use middle mouse button to paste, type something else into FreeTube search, click the X button to clear it, paste again.
Desktop (please complete the following information):
Additional context
#2019 (comment) user confirms that this is the expected behaviour for the X button. Cheers