Fix: wrong info displayed when quickly navigate from a channel to another #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… another (Invidious)
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
|
This also happens on the local api FreeTube_VFrY1iewHb.mp4Would also like to see a fix for that in this PR |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
May 22, 2022 12:10
Head branch was pushed to by a user without write access
hockerschwan
changed the title
|
Local api added |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
May 22, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
PikachuEXE and
absidue
PikachuEXE
requested changes
May 24, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
May 24, 2022 15:11
Head branch was pushed to by a user without write access
|
@hockerschwan ready for review again? |
|
yes please |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 24, 2022
PikachuEXE
approved these changes
May 25, 2022
absidue
approved these changes
May 25, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #1545
Description
Holds id in
getChannelInfoInvidiousetc. and compares to this.id, if they are different (route changed), do nothing.Screenshots (if appropriate)
Before:
ezgif-4-9792565c55.mp4
After:
ezgif-4-5510342c91.mp4
Desktop (please complete the following information):