-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev] Allow more locales to be used by FreeTube #2322
[dev] Allow more locales to be used by FreeTube #2322
Conversation
forgot to check Basque/Euskera
@efb4f5ff-1298-471a-8973-3d47447115dc are you having issues on this branch too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to put those locales in more lines?
My brain hurts reading that long line...
@PikachuEXE i guess thats a no. So could u pretty please use your ⚡️ to approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long horizontal lines sucks...
[dev] Allow more locales to be used by FreeTube
Pull Request Type
Please select what type of pull request this is:
Related issue
I noticed a lot of changes recently for languages that are not currently displayed in the FreeTube app
Description
This PR allows the following locales to be selected:
ca (català/catalan), es_AR, et (Eesti/Estonian), eu (euskera/basque), ko (한국인/ korean), lt (lietuvių/lithuanian)
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Please describe shortly how you tested it and whether there are any ramifications remaining.
I tested by changing my locale to the languages that were added.
Desktop (please complete the following information):
Additional context
Tested on dev branch with latest locale changes (Basque in particular got a lot of updates not in the RC branch so it won't appear to be translated as much on that branch)