New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for banner and too far scrolling #2398
Fix for banner and too far scrolling #2398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test locally (for this branch no the one for dev branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot my line comment...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Fix for banner and too far scrolling
Pull Request Type
Please select what type of pull request this is:
Related issue
From dev channel
Description
The last fix for the overflowing banner introduced a bug that lets you scroll past the video section on any page.
This is now fixed by a small restructuring of how the app layout works and how it is styled
Testing (for code that is not small enough to be easily understandable)
Tested with and without banner
Desktop (please complete the following information):