Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cmd+M unable to minimize window when viewing video #2486

Merged

Conversation

PikachuEXE
Copy link
Collaborator

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue
#2485

Description
Fix Cmd+M to be able to minimize a window when viewing a video
Tested on MacOS only

Screenshots (if appropriate)
Please add before and after screenshots if there is a visible change.

Testing (for code that is not small enough to be easily understandable)

  • View random video
  • Test both M & Ctrl/Cmd+M

Desktop (please complete the following information):

  • OS: MacOS
  • OS Version: 12.1
  • FreeTube version: 33cf88c

Additional context
Documented keyboard shortcuts: https://docs.freetubeapp.io/usage/keyboard-shortcuts/

@PikachuEXE PikachuEXE added the OS: macos All issues related to Macs, as we do not have one to test things label Aug 16, 2022
@PrestonN PrestonN enabled auto-merge (squash) August 16, 2022 02:03
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows 10

@PrestonN PrestonN merged commit e0e7b50 into FreeTubeApp:development Aug 16, 2022
@absidue absidue linked an issue Aug 16, 2022 that may be closed by this pull request
4 tasks
@PikachuEXE PikachuEXE deleted the fix/cmd+m/minimize-window branch November 2, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: macos All issues related to Macs, as we do not have one to test things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Command+M" do not work in some Invidious Instance
5 participants