Urdu lang #2509

ArshErgon · 2022-08-26T05:07:01Z

added support for urdu language.

ChunkyProgrammer · 2022-08-26T11:10:45Z

We suggest using https://hosted.weblate.org/engage/free-tube/ to add new languages

ChunkyProgrammer · 2022-08-28T23:52:35Z

static/locales/ur.yaml

+Search Filters:
+  Search Filters: 'فلٹرز تلاش کریں۔'
+  Sort By:
+    Sort By: Sort By


I think the non translated ones should be set to empty strings
Ex:

Suggested change

Sort By: Sort By

Sort By: ''

ArshErgon

re-edit the language

ChunkyProgrammer

Two more english texts

ChunkyProgrammer · 2022-08-29T10:33:12Z

static/locales/ur.yaml

+Screenshot Success: 'اسکرین شاٹ کو بطور "$" محفوظ کیا گیا'
+Screenshot Error: 'اسکرین شاٹ ناکام ہو گیا۔ $'
+
+Yes: Yes


Suggested change

Yes: Yes

Yes: ''

ChunkyProgrammer · 2022-08-29T10:33:31Z

static/locales/ur.yaml

+Screenshot Error: 'اسکرین شاٹ ناکام ہو گیا۔ $'
+
+Yes: Yes
+No: No


Suggested change

No: No

No: ''

Sorry, its done, can you please tell me how can I be running the project locally? will npm start or yarn dev will work?

yarn install to install the dependencies and then yarn dev to run in dev mode.

What absidue said + if you're trying to test out your language, you'll need to add "ur" to

FreeTube/src/renderer/i18n/index.js

Line 11 in cb63b12

const activeLocales = ['en-US', 'en_GB', 'ar', 'bg', 'ca', 'cs', 'da', 'de-DE', 'el', 'es', 'es_AR', 'es-MX', 'et', 'eu', 'fi', 'fr-FR', 'gl', 'he', 'hu', 'hr', 'id', 'is', 'it', 'ja', 'ko', 'lt', 'nb_NO', 'nl', 'nn', 'pl', 'pt', 'pt-BR', 'pt-PT', 'ro', 'ru', 'sk', 'sl', 'sr', 'sv', 'tr', 'uk', 'vi', 'zh-CN', 'zh-TW']

ChunkyProgrammer · 2022-08-29T20:19:38Z

@ArshErgon will you be adding more translations or would you want this to be merged as is?

ArshErgon · 2022-08-31T14:21:01Z

@ChunkyProgrammer yes, I will be adding more languages, but at now, not.

efb4f5ff-1298-471a-8973-3d47447115dc · 2022-08-31T14:25:10Z

@ArshErgon more languages or more translations of this language

ArshErgon · 2022-08-31T14:33:34Z

@efb4f5ff-1298-471a-8973-3d47447115dc I will be adding more languages.

ChunkyProgrammer · 2022-08-31T15:20:57Z

tested, there are some issues with the yaml format. would you want me to push the commit to fix the yaml? @ArshErgon

ChunkyProgrammer

Make the following changes and this PR should be ready to approve (you should also be able to test your changes once these changes are made to make the yaml valid)

ChunkyProgrammer · 2022-09-05T22:03:13Z

static/locales/ur.yaml

+  Settings: 
+  The app needs to restart for changes to take effect. Restart and apply change?: 'دی
+     تبدیلیاں اثر انداز ہونے کے لیے ایپ کو دوبارہ شروع کرنے کی ضرورت ہے۔ دوبارہ شروع کریں اور تبدیلی کا اطلاق کریں؟'
+  General Settings: 'ترتیبات'


This key should remain blank (General Settings is translated below)

Suggested change

General Settings: 'ترتیبات'

General Settings:

ChunkyProgrammer · 2022-09-05T22:04:13Z

static/locales/ur.yaml

+Playlists: ''
+User Playlists:
+  Your Playlists: ''
+  Playlist Message: 'یہ صفحہ مکمل طور پر کام کرنے والی پلے لسٹس کا عکاس نہیں ہے۔ یہ صرف


remove outer 's as string contains one in it

Suggested change

Playlist Message: 'یہ صفحہ مکمل طور پر کام کرنے والی پلے لسٹس کا عکاس نہیں ہے۔ یہ صرف

Playlist Message: یہ صفحہ مکمل طور پر کام کرنے والی پلے لسٹس کا عکاس نہیں ہے۔ یہ صرف

ChunkyProgrammer · 2022-09-05T22:05:04Z

static/locales/ur.yaml

+  Your Playlists: ''
+  Playlist Message: 'یہ صفحہ مکمل طور پر کام کرنے والی پلے لسٹس کا عکاس نہیں ہے۔ یہ صرف
+     ان ویڈیوز کی فہرست بناتا ہے جنہیں آپ نے محفوظ کیا ہے یا پسند کیا ہے۔ جب کام ختم ہو جائے تو سب
+     فی الحال یہاں موجود ویڈیوز کو 'پسندیدہ' پلے لسٹ میں منتقل کر دیا جائے گا۔'


Suggested change

فی الحال یہاں موجود ویڈیوز کو 'پسندیدہ' پلے لسٹ میں منتقل کر دیا جائے گا۔'

فی الحال یہاں موجود ویڈیوز کو 'پسندیدہ' پلے لسٹ میں منتقل کر دیا جائے گا۔

ChunkyProgrammer · 2022-09-05T22:06:25Z

static/locales/ur.yaml

+    Current Invidious Instance: ''
+    # $ is replaced with the default Invidious instance
+    The currently set default instance is $: ''
+    No default instance has been set:''


a colon and a space(": ") should separate keys from values

Suggested change

No default instance has been set:''

No default instance has been set: ''

ChunkyProgrammer · 2022-09-05T22:06:44Z

static/locales/ur.yaml

+      No Action: ''
+  Theme Settings:
+    Theme Settings: ''
+    Match Top Bar with Main Color:''


Suggested change

Match Top Bar with Main Color:''

Match Top Bar with Main Color: ''

ChunkyProgrammer · 2022-09-05T22:06:53Z

static/locales/ur.yaml

+    Expand Side Bar by Default: ''
+    Disable Smooth Scrolling: ''
+    UI Scale: ''
+    Hide Side Bar Labels:''


Suggested change

Hide Side Bar Labels:''

Hide Side Bar Labels: ''

ChunkyProgrammer · 2022-09-05T22:07:01Z

static/locales/ur.yaml

+    UI Scale: ''
+    Hide Side Bar Labels:''
+    Base Theme:
+      Base Theme:''


Suggested change

Base Theme:''

Base Theme: ''

ChunkyProgrammer · 2022-09-05T22:08:48Z

static/locales/ur.yaml

+    Ignore Warnings: 'انتباہات کو دبائیں جب موجودہ بیرونی کھلاڑی تعاون نہیں کرتا ہے۔
+       موجودہ کارروائی (مثلاً پلے لسٹ کو تبدیل کرنا، وغیرہ)۔'
+    Custom External Player Arguments: 
+    'کوئی بھی حسب ضرورت کمانڈ لائن آرگومنٹس، جو سیمیکولنز (';') سے الگ کیے گئے ہیں،


Suggested change

'کوئی بھی حسب ضرورت کمانڈ لائن آرگومنٹس، جو سیمیکولنز (';') سے الگ کیے گئے ہیں،

کوئی بھی حسب ضرورت کمانڈ لائن آرگومنٹس، جو سیمیکولنز (';') سے الگ کیے گئے ہیں،

ChunkyProgrammer · 2022-09-05T22:08:59Z

static/locales/ur.yaml

+       موجودہ کارروائی (مثلاً پلے لسٹ کو تبدیل کرنا، وغیرہ)۔'
+    Custom External Player Arguments: 
+    'کوئی بھی حسب ضرورت کمانڈ لائن آرگومنٹس، جو سیمیکولنز (';') سے الگ کیے گئے ہیں،
+       آپ بیرونی کھلاڑی کو منتقل کرنا چاہتے ہیں۔'


Suggested change

آپ بیرونی کھلاڑی کو منتقل کرنا چاہتے ہیں۔'

آپ بیرونی کھلاڑی کو منتقل کرنا چاہتے ہیں۔

ChunkyProgrammer · 2022-09-20T12:34:53Z

As mentioned above, it would be a lot faster for future language contributions to be done through our weblate https://hosted.weblate.org/engage/free-tube/ . File is valid YAML so lgtm. Thanks so much for contributing to freetube, we hope to see more contributions in the future :)

ArshErgon added 2 commits August 26, 2022 09:33

added support for urdu-lang

932f59a

Merge branch 'FreeTubeApp:development' into urdu-lang

e4c5a7a

PrestonN enabled auto-merge (squash) August 26, 2022 05:07

efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 26, 2022

ChunkyProgrammer reviewed Aug 28, 2022

View reviewed changes

re-edit

e9e6bb0

auto-merge was automatically disabled August 29, 2022 08:21
Head branch was pushed to by a user without write access

PrestonN enabled auto-merge (squash) August 29, 2022 08:21

ArshErgon commented Aug 29, 2022

View reviewed changes

ArshErgon requested a review from ChunkyProgrammer August 29, 2022 08:22

ChunkyProgrammer reviewed Aug 29, 2022

View reviewed changes

re-edit

44a0864

auto-merge was automatically disabled August 29, 2022 12:05
Head branch was pushed to by a user without write access

PrestonN enabled auto-merge (squash) August 29, 2022 12:05

ChunkyProgrammer reviewed Sep 5, 2022

View reviewed changes

ChunkyProgrammer added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 9, 2022

re-edit changes

8a5130e

auto-merge was automatically disabled September 12, 2022 03:29
Head branch was pushed to by a user without write access

PrestonN enabled auto-merge (squash) September 12, 2022 03:30

Merge branch 'FreeTubeApp:development' into urdu-lang

c519128

ArshErgon requested review from absidue and ChunkyProgrammer and removed request for absidue September 12, 2022 03:35

ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Sep 20, 2022

ChunkyProgrammer requested review from absidue, efb4f5ff-1298-471a-8973-3d47447115dc and PikachuEXE September 20, 2022 12:33

ChunkyProgrammer approved these changes Sep 20, 2022

View reviewed changes

PikachuEXE approved these changes Sep 20, 2022

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Sep 20, 2022

View reviewed changes

PrestonN merged commit 60166eb into FreeTubeApp:development Sep 20, 2022

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Urdu lang #2509

Urdu lang #2509

ArshErgon commented Aug 26, 2022

ChunkyProgrammer commented Aug 26, 2022

ChunkyProgrammer Aug 28, 2022

ArshErgon left a comment

ChunkyProgrammer left a comment •

edited

Loading

ChunkyProgrammer Aug 29, 2022

ChunkyProgrammer Aug 29, 2022

ArshErgon Aug 29, 2022

absidue Aug 29, 2022

ChunkyProgrammer Aug 29, 2022

ChunkyProgrammer commented Aug 29, 2022

ArshErgon commented Aug 31, 2022

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 31, 2022

ArshErgon commented Aug 31, 2022

ChunkyProgrammer commented Aug 31, 2022

ChunkyProgrammer left a comment •

edited

Loading

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer Sep 5, 2022

ChunkyProgrammer commented Sep 20, 2022 •

edited

Loading

	Playlist Message: 'یہ صفحہ مکمل طور پر کام کرنے والی پلے لسٹس کا عکاس نہیں ہے۔ یہ صرف
	Playlist Message: یہ صفحہ مکمل طور پر کام کرنے والی پلے لسٹس کا عکاس نہیں ہے۔ یہ صرف

	فی الحال یہاں موجود ویڈیوز کو 'پسندیدہ' پلے لسٹ میں منتقل کر دیا جائے گا۔'
	فی الحال یہاں موجود ویڈیوز کو 'پسندیدہ' پلے لسٹ میں منتقل کر دیا جائے گا۔

	No default instance has been set:''
	No default instance has been set: ''

	Match Top Bar with Main Color:''
	Match Top Bar with Main Color: ''

	'کوئی بھی حسب ضرورت کمانڈ لائن آرگومنٹس، جو سیمیکولنز (';') سے الگ کیے گئے ہیں،
	کوئی بھی حسب ضرورت کمانڈ لائن آرگومنٹس، جو سیمیکولنز (';') سے الگ کیے گئے ہیں،

	آپ بیرونی کھلاڑی کو منتقل کرنا چاہتے ہیں۔'
	آپ بیرونی کھلاڑی کو منتقل کرنا چاہتے ہیں۔

Urdu lang #2509

Urdu lang #2509

Conversation

ArshErgon commented Aug 26, 2022

ChunkyProgrammer commented Aug 26, 2022

Choose a reason for hiding this comment

ArshErgon left a comment

Choose a reason for hiding this comment

ChunkyProgrammer left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChunkyProgrammer commented Aug 29, 2022

ArshErgon commented Aug 31, 2022

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 31, 2022

ArshErgon commented Aug 31, 2022

ChunkyProgrammer commented Aug 31, 2022

ChunkyProgrammer left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChunkyProgrammer commented Sep 20, 2022 • edited Loading

ChunkyProgrammer left a comment •

edited

Loading

ChunkyProgrammer left a comment •

edited

Loading

ChunkyProgrammer commented Sep 20, 2022 •

edited

Loading