Switch back to upstream ytdl-core now that it has been updated #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
added
PR: dependencies
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
ChunkyProgrammer
approved these changes
Aug 26, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 26, 2022
PikachuEXE
approved these changes
Aug 26, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch back to upstream ytdl-core now that it has been updated
Pull Request Type
Description
Upstream ytdl-core, has received an update (4.11.1) that resolves the issues properly, which means we can stop using my fork that had the quick fix in it. The changelog for the 4.11.1 is missing the most important part, that it includes this PR fent/node-ytdl-core#1126 that updates the parsing logic.
Testing (for code that is not small enough to be easily understandable)
Seems to work just as well, maybe even better than the quick fix on my fork.
Desktop (please complete the following information):
Additional context
I'll delete the branch on my fork when this is merged.