Fix some development code not getting optimised out #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
added
the
PR: waiting for review
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
PikachuEXE
approved these changes
Sep 22, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 24, 2022
ChunkyProgrammer
approved these changes
Sep 26, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some development code not getting optimised out
Important note
We may remove your pull request if you do not use this provided PR template correctly.
Pull Request Type
Please select what type of pull request this is:
Description
Webpack doesn't know about vue's computed properties or vuex stores, so it doesn't know how to optimise them out. This PR fixes that by marking development only code in a way that webpack understands, so it can remove the dead code properly while optimising the release builds. This PR also gets rid of some unnecessary
isDevcomputed properties. This change doesn't make a big size or speed difference but even a 849 byte decrease in size and an unmeasurably small performance improvement are better than including dead code in a release build.Screenshots (if appropriate)
Testing (for code that is not small enough to be easily understandable)
yarn devandyarn buildOpening the settings will test both the geolocation names for trending the fetching of the invidious instances.
Desktop (please complete the following information):