Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app menu to add items for going back/forward in router history #2933

Merged
merged 1 commit into from Dec 11, 2022
Merged

Update app menu to add items for going back/forward in router history #2933

merged 1 commit into from Dec 11, 2022

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Dec 8, 2022 •
edited

Update app menu to add items for going back/forward in router history

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

For #1869

Description

Update app menu to add items for going back/forward in router history

Screenshots

image

Testing

Desktop

  • OS: macOS
  • OS Version: 12.6.1
  • FreeTube version: 7abe97d

Additional context

Does that mean we can move the implementation of keyboard shortcut to the new menu item?

Edit: Wait that wouldn't work on web build

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 8, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 8, 2022 02:10
@absidue
Copy link
Member

absidue commented Dec 8, 2022 •
edited

The back and forward shortcuts only get activated on the electron build (App.js lines 161 and 295), so moving it to the main process is fine. The code in this PR should be changed so that the back and forward buttons get updated (see how it's done in App.js and the top-nav component).

@PikachuEXE PikachuEXE force-pushed the feature/shortcuts/history-forward-back branch from 62ac0e5 to 7a0be8e Compare December 9, 2022 01:21
@PikachuEXE
Copy link
Collaborator Author

@absidue Updated

@PikachuEXE
Copy link
Collaborator Author

@efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer PikaPika~

@FreeTubeBot FreeTubeBot merged commit e96116a into FreeTubeApp:development Dec 11, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot