Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context menu entries to copy YouTube and Invidious links #2957

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Add context menu entries to copy YouTube and Invidious links #2957

merged 1 commit into from
Dec 14, 2022

Conversation

absidue
Copy link
Member

@absidue absidue commented Dec 13, 2022

Add context menu entries to copy YouTube and Invidious links

Pull Request Type

  • Feature Implementation

Related issue

based on discussions on #2951

Description

This pull request builds on top of the copy YouTube link functionality introduced in #2951, adding the ability to copy the in-app links as YouTube or Invidious ones.

Screenshots

new-context-menu

Testing

  1. Right click on menu items in the side bar
  2. Right click on videos, channels and playlists in channels, search results, playlists, up next and trending
  3. Right click on channel name and image on the watch and playlist pages
  4. Right click on links in video descriptions, to make sure that Copy Link shows up and the other two entries don't

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 13, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 13, 2022 17:22
PikachuEXE
PikachuEXE approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@FreeTubeBot FreeTubeBot merged commit 29f5e38 into FreeTubeApp:development Dec 14, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 14, 2022
@absidue absidue deleted the copy-youtube-invidious branch December 14, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot