Migrate playlists on the watch page to YouTube.js #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
PR: dependencies
ChunkyProgrammer
approved these changes
Dec 16, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 16, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate playlists on the watch page to YouTube.js
Pull Request Type
Description
This pull request migrates the playlists view on the watch page to YouTube.js, this removes the need for the ytpl dependency, as the playlist page was migrated in an earlier PR. Yay! 馃槃
Like the previous implementation this will paginate through the entire playlist, which means the playlist view is slow to load for lots of videos, however the benefits of having all videos there outweigh the wait. In the future we might want to introduce a timeout and then just show the videos that have been fetched up until then.
Testing
playlist with 100 videos, only a single page
https://www.youtube.com/playlist?list=PL4fGSI1pDJn6puJdseH2Rt9sMvt9E2M4i
playlist with 872 videos, multiple pages
https://www.youtube.com/playlist?list=PLbMjU_TVMIFvmkQ871iUvE5gy5ezXc6hE
Desktop