Fix the trending and watch pages swallowing the arrow key events #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
previously approved these changes
Feb 7, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Feb 8, 2023
I think this or is just for fixing the trending page |
Ah if that is the case i can approve it but this pr doesnt fully close the issue. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
absidue
dismissed stale reviews from PikachuEXE and ChunkyProgrammer
via
4d58bd1
absidue
changed the title
absidue
changed the title
absidue
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc,
PikachuEXE and
ChunkyProgrammer
absidue
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 9, 2023
PikachuEXE
approved these changes
Feb 10, 2023
ChunkyProgrammer
approved these changes
Feb 10, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the trending and watch pages swallowing the arrow key events
Pull Request Type
Related issue
closes #3160
Description
Currently the trending and watch pages swallow the arrow key events, even when you use the alt+arrow key shortcuts.
Testing
Focus the different trending tabs with the left and right arrow keys and also try navigating back and forward with alt+arrow key
Desktop