Add RYD and RYD Proxy support

[ChunkyProgrammer]

Add RYD and RYD Proxy support

Pull Request Type

• Feature Implementation

Related issue

closes #1927
Credit to @petaded for #1982

Description

This PR adds support for the ReturnYouTubeDislikes api as well a RYD proxies
https://github.com/TeamPiped/RYD-Proxy

Testing

RYD Disabled - (Test with local and invidious)

1. have ryd disabled
2. test a video (ex: https://www.youtube.com/watch?v=YbJOTdZBX1g )
3. dislikes aren't fetched and aren't shown

RYD Enabled + using RYD-proxy - (Test with local and invidious)

1. have ryd enabled
2. use ryd-proxy (ex: kavin's instance [this is the default instance])
3. test a video (ex: https://www.youtube.com/watch?v=YbJOTdZBX1g )
4. see dislikes + like/dislike bar

RYD Enabled + using official API - (Test with local or invidious)

1. have ryd enabled
2. use official api
3. test a video (ex: https://www.youtube.com/watch?v=YbJOTdZBX1g )
4. see dislikes + like/dislike bar

Desktop

• OS: Windows
• OS Version: 11
• FreeTube version: 0.18.0

[PikachuEXE]

Tested both local and Invidious

Official API = https://returnyoutubedislikeapi.com/Votes (Will be modified on paste)
From https://returnyoutubedislikeapi.com/swagger/index.html and/or https://www.returnyoutubedislike.com/docs/fetching

[absidue]

Tested locally and it works

[efb4f5ff-1298-471a-8973-3d47447115dc]

Because we are using a proxy i think its better to put it in the proxy tab instead of its own tab

[ChunkyProgrammer]

Because we are using a proxy i think its better to put it in the proxy tab instead of its own tab

You dont have to use the proxy though

[efb4f5ff-1298-471a-8973-3d47447115dc]

You dont have to use the proxy though

Doesnt that go against #1927 (comment)?

[ChunkyProgrammer]

You dont have to use the proxy though

Doesnt that go against #1927 (comment)?

It uses the proxy by default but allows people to change it to the official api if they want to 🙂

[efb4f5ff-1298-471a-8973-3d47447115dc]

Sorry wasnt clear enough with that one. Based on #1927 (comment) i wouldnt feel comfortable to allow setting it to the official api. I would only allow setting it to other proxies if that is going to be a thing TeamPiped/RYD-Proxy#6

[absidue]

@efb4f5ff-1298-471a-8973-3d47447115dc I think allowing the user to set it to the official instance, is okay. The user has to make a conscious decision to use the official instance, so it's on them. Now that the code is already written, our only argument against it is "we don't think the official instance is trustworthy, so we are going to explicitly block it in FreeTube", which would be us preventing users from doing something trivial because of our personal opinions.

I see it similarly to using a VPN, our docs clearly recommend using one, but the user is allowed to use the local API without a VPN if they want to. You have to remember that we have a wide variety of users using FreeTube, some with extreme threat models and others that just use FreeTube for the features (no ads is probably a big one) and don't really care about privacy.

[PikachuEXE]

Hmmm we have "local API" which is connecting to YT directly right?
So isn't that a "privacy concern" already?

Or displays a warning when official API is used?

Discuss with @PrestonN ?

[ChunkyProgrammer]

Will be closing this PR until RYD is more open

[ghost]

does someone maintain a fork for RYD functionality with latest releases?

it's ridiculous to complain about RYD openness or lack thereof while pinging youtube servers for content.

[absidue]

@jackloomen The RYD database needs to be public for running an alternative instance to be viable. SponsorBlock for example not only is fully open source but also provides regular database dumps.

YouTube is the only exception, because this is literally a third-party YouTube client and we can't get around it without loosing functionality.

[ChunkyProgrammer]

does someone maintain a fork for RYD functionality with latest releases?

I merged in the latest changes to my RYD branch. It's pretty light so it should be fairly straight forward to merge in more changes in the future if you or someone else would like to do that (I don't want to maintain the branch unless it's going into FreeTube). If you'd like to build the branch, you can follow this guide: https://docs.freetubeapp.io/development/building-from-source .

If you'd like the RYD changes to be officially added into FreeTube, feel free to give a thumbs up reaction to the issue for open sourcing the backend and the issue providing data dumps in the return-youtube-dislike repo 😄

[RayZ3R0]

@jackloomen The RYD database needs to be public for running an alternative instance to be viable. SponsorBlock for example not only is fully open source but also provides regular database dumps.

YouTube is the only exception, because this is literally a third-party YouTube client and we can't get around it without loosing functionality.

Couldn't this be made an option in the settings so you can turn it on or off depending on the user? I am privacy concerned but I also need the dislikes count. I don't think it'll be an issue for anyone if its toggle-able