Fix video throttling because of range header #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
|
Is the string always "bytes="? Asking because https://github.com/unixfox/invidious-custom/blob/master/patches/007-range-header.patch is slightly different |
|
in my testing it was, but i'll switch to the split way, as that seems more robust |
ChunkyProgrammer
approved these changes
Feb 28, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 28, 2023
PikachuEXE
approved these changes
Mar 1, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 1, 2023
* development: Fix video throttling because of range header (FreeTubeApp#3234) Translated using Weblate (Greek) Migrate channel related functionality to YouTube.js (FreeTubeApp#3143) Differentiate links in readme.md (FreeTubeApp#3224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix video throttling because of range header
Pull Request Type
Related issue
yt-dlp/yt-dlp#6369
Description
YouTube now throttles the DASH formats if you use the HTTP Range header, the Range header is the standardised way of telling a server you only want part of a file. For a while YouTube has been using a
rangequery parameter instead of the standard header, however now they seem to mandate it for the DASH formats, if you don't want your streams to be throttled.Testing
It looks like they haven't rolled the throttling out for everyone on every video yet.
So you can try multiple videos and also make sure that no new errors show up because of this change.
Desktop