Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update export data default filename to use today's date in local timezone instead of UTC #3236

Merged
merged 1 commit into from Mar 2, 2023
Merged

Update export data default filename to use today's date in local timezone instead of UTC #3236

merged 1 commit into from Mar 2, 2023

Conversation

PikachuEXE
Copy link
Collaborator

Update export data default filename to use today's date in local timezone instead of UTC

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

N/A

Description

FT uses UTC date as default filename for data export
This PR makes it uses local timezone instead
e.g. I export data before 2023-03-01 8:00am on UTC+8 timezone, default filename 2023-02-28 => 2023-03-01

Screenshots

N/A

Testing

Timezone with plus diff:

  • Update computer timezone to plus diff (up to +11 or +12?)
  • Update time to before 11am
  • Export data to ensure default filename set to today not yesterday

Desktop

  • OS: MacOS
  • OS Version: 12.6.2
  • FreeTube version: f56f6e7

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 1, 2023 02:06
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 1, 2023
ChunkyProgrammer
ChunkyProgrammer approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@FreeTubeBot FreeTubeBot merged commit 5713e66 into FreeTubeApp:development Mar 2, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 2, 2023
@SkyTheGreatOne SkyTheGreatOne mentioned this pull request Aug 18, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot