Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subscription view to render video as watched ASAP #3353

Merged
merged 1 commit into from Mar 26, 2023
Merged

Update subscription view to render video as watched ASAP #3353

merged 1 commit into from Mar 26, 2023

Conversation

PikachuEXE
Copy link
Collaborator

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

N/A

Description

Before this change a view change (back & forth) is needed if video is watched in another window

Screenshots

Lazy

Testing

  • Subscribe some any channel
  • Refresh subscription view
  • Open an unwatched video in new window (middle click)
  • Wait for video to play a little bit (to ensure it's marked as watched)
  • Go back to last window with subscription view, ensure that video is marked as watched

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

I keep having trouble remembering which video is watched or not while I watch most videos in new windows

@PikachuEXE
* Update subscription view to render video as watched ASAP
707b90a 
Before this change a view change (back & forth) is needed if video is watched in another window
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 24, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 24, 2023 08:47
@FreeTubeBot FreeTubeBot merged commit 6e44f1a into FreeTubeApp:development Mar 26, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 26, 2023
@PikachuEXE PikachuEXE deleted the feature/video-watch-state-update branch August 23, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot