New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update watch view playlist component to auto scroll to current video #3399
Update watch view playlist component to auto scroll to current video #3399
Conversation
e19195a
to
820001f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nextTick
actually doesn't work for items near the end of a playlist
LGTM, i dont think its that big of a deal because even if it's not the current video on top of the list, thumbnail of the current video playing is still in view.
This reverts commit 9215b0f.
@PikachuEXE could u explain to me why u reverted in the latest commit to timeout? To me the nextTick didn't felt like it introduced a major issue with the items not working at the end of the playlist. Am i missing something here? |
With |
@absidue @ChunkyProgrammer |
I have following changes but still have I think Let me know if this change is preferred or the current pushed version |
Looks good, please use |
@absidue I assume you want me to go with the latest attempt to remove Additional change: |
Pull Request Type
Related issue
Fixes #1521
Description
Very strange/inconvenient to me that the playlist is not showing current video in playlist when playing a video in a playlist
This PR makes it auto scroll to current video
Screenshots
Screen.Recording.2023-04-04.at.14.19.14.mov
Testing
Test with both Local & Invidious API
Test with different widths, sorting
Desktop
Additional context