Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IV: Fix search cache issues when fetching more #3486

Merged
merged 3 commits into from
May 13, 2023
Merged

IV: Fix search cache issues when fetching more #3486

merged 3 commits into from
May 13, 2023

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented May 3, 2023 •
edited
Loading

IV: Fix search cache issues when fetching more

Pull Request Type

  • Bugfix

Related issue

closes #1900

Description

  • save next page data for fetch more in cache
  • add apiUsed to cache

Testing

See: #1900 (comment)

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 0.18.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 3, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 3, 2023 20:13
PikachuEXE
PikachuEXE requested changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested #1900 (comment)

src/renderer/store/modules/utils.js Outdated Show resolved Hide resolved
@ChunkyProgrammer @PikachuEXE
Add comment
57af984 
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
@absidue
Copy link
Member

absidue commented May 5, 2023

Erm so weird thing happens with these steps on the local API:

  1. Search for something
  2. Click load more
  3. Navigate back to the previous page
  4. Navigate forward again
  5. Click load more

loading icon shows up and you only have one page of results, even though there should be 3

@PikachuEXE
Copy link
Collaborator

I think #1900 is not about Local API?
Not saying we shouldn't fix it but not sure how easy to fix the Local API issue
If easy enough let's fix it in this PR
If not let's merge this PR first and create a separate issue (or draft PR)

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

I think #1900 is not about Local API? Not saying we shouldn't fix it but not sure how easy to fix the Local API issue If easy enough let's fix it in this PR If not let's merge this PR first and create a separate issue (or draft PR)

it isnt about the local api? maybe see #1900 (comment) to understand the issue better?

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes May 6, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, lgtm

@ChunkyProgrammer
Copy link
Member Author

Absidue is mentioning a regression from this PR. I believe I fixed it here: 63ed793

🙂

@FreeTubeBot FreeTubeBot merged commit ff19c23 into FreeTubeApp:development May 13, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 13, 2023
@ChunkyProgrammer ChunkyProgrammer deleted the fix-iv-search-cache-issues branch August 15, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ChunkyProgrammer @absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @FreeTubeBot