Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playlist thumbnail not getting proxied through Invidious #3581

Merged
merged 1 commit into from May 23, 2023
Merged

Fix playlist thumbnail not getting proxied through Invidious #3581

merged 1 commit into from May 23, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented May 22, 2023

Fix playlist thumbnail not getting proxied through Invidious

Pull Request Type

  • Bugfix

Description

Fix playlist thumbnail not getting proxied through Invidious on the playlist page. Copied the logic over from ft-list-video.

Screenshots

before:
before

after:
after

Testing

  1. Set the API to Invidious
  2. Open a playlist e.g. https://www.youtube.com/playlist?list=PL8mG-RkN2uTwKxRN7Qd_qTNn6lqHkdN8g
  3. Use the select element item in the devtools (CTRL+SHIFT+C) to select the playlist thumbnail
  4. Check that the src attribute of the image starts with the Invidious instance you are using

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 15b8dff

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 22, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 22, 2023 20:43
@FreeTubeBot FreeTubeBot merged commit 6f95673 into FreeTubeApp:development May 23, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 23, 2023
@absidue absidue deleted the playlist-thumbnail-invidious branch May 23, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot