Channels: Add support for release and podcast tab #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: dependencies
PikachuEXE
reviewed
Jul 15, 2023
ChunkyProgrammer
force-pushed
the
add-releases-and-podcasts-tab
branch
from
6840513
to
bf0c857
Compare
ChunkyProgrammer
force-pushed
the
add-releases-and-podcasts-tab
branch
from
bf0c857
to
fdfc742
Compare
ChunkyProgrammer
requested review from
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
|
So the IV PR to support this just got merged. Will u make a commit here to support it or a separate PR? |
ChunkyProgrammer
changed the title
I updated this PR to add IV support |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jul 16, 2023
PikachuEXE
previously approved these changes
Jul 17, 2023
|
Is this error related? |
|
That error is unrelated (there's a pr open in invidious for it, basically community wasnt using innertube and is getting rate limited now) |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ChunkyProgrammer
dismissed stale reviews from PikachuEXE and efb4f5ff-1298-471a-8973-3d47447115dc
via
89cf671
ChunkyProgrammer
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jul 17, 2023
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ChunkyProgrammer
added
the
PR: waiting for review
ChunkyProgrammer
removed
the
PR: dependencies
PikachuEXE
previously approved these changes
Jul 17, 2023
absidue
reviewed
Jul 18, 2023
ChunkyProgrammer
dismissed stale reviews from PikachuEXE and efb4f5ff-1298-471a-8973-3d47447115dc
via
98e5d09
|
Looks like the no releases message shows up even when there are releases: |
absidue
reviewed
Jul 18, 2023
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
PikachuEXE
approved these changes
Jul 19, 2023
ChunkyProgrammer
requested review from
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 19, 2023
absidue
approved these changes
Jul 19, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channels: Add support for release and podcast tab
Pull Request Type
Related issue
closes #3763
Description
Adds Podcasts and Releases tabs to channels (local api only).
This PR also:
channel/id/subResourceinstead ofchannel/subResource/id)Screenshots
Testing
Using both the Local API and the Invidious API the following tests should be done:
Channel with podcasts: https://www.youtube.com/channel/UCGk1LitxAZVnqQn0_nt5qxw
Channel with releases: https://www.youtube.com/channel/UC5CwaMl1eIgY8h02uZw7u8A
Other test (trying to access a tab that doesn't exist)
Desktop