Add external player support for Clapper #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
absidue and
ChunkyProgrammer
ChunkyProgrammer
approved these changes
Aug 21, 2023
PikachuEXE
approved these changes
Aug 22, 2023
absidue
approved these changes
Aug 23, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add external player support for Clapper
Pull Request Type
Related issue
closes #3914
Description
Adds support for opening videos using the Clapper media player. Clapper does not expose any commandline parameters and does not support opening playlists.
Screenshots
Testing
Only tested the Clapper flatpak build in a Debian VM due to gstreamer hell with the regular packages across multiple distros, but the executable is correct so should work if you have a working gstreamer setup that can parse Youtube URLs.
Desktop
Additional context