Add subscribed icon to comments #4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Sep 8, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
September 8, 2023 11:35
Head branch was pushed to by a user without write access
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Sep 8, 2023
There was a problem hiding this comment.
In https://youtu.be/nXkgbmr3dRA LTT replied on the top comment but if u go to the reply u dont see the subscribed FT icon
auto-merge was automatically disabled
September 8, 2023 16:39
Head branch was pushed to by a user without write access
ChunkyProgrammer
added
PR: waiting for review
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
Whoops, truly and oversight of oversights |
PikachuEXE
previously approved these changes
Sep 9, 2023
absidue
reviewed
Sep 9, 2023
src/renderer/components/watch-video-comments/watch-video-comments.css
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
September 10, 2023 01:31
Head branch was pushed to by a user without write access
…nts.css Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
absidue and
PikachuEXE
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 10, 2023
absidue
approved these changes
Sep 10, 2023
PikachuEXE
approved these changes
Sep 10, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 11, 2023
* development: (46 commits) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Translated using Weblate (Chinese (Simplified)) Add subscribed icon to comments (FreeTubeApp#4007) Translated using Weblate (Icelandic) Translated using Weblate (Czech) Translated using Weblate (Bulgarian) Translated using Weblate (Polish) Translated using Weblate (Arabic) Translated using Weblate (Greek) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Hungarian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Ukrainian) Translated using Weblate (Spanish) Translated using Weblate (Hebrew) Translated using Weblate (Turkish) Search: Add hashtags to results (FreeTubeApp#3780) Implement right-to-left interface (FreeTubeApp#3970) ... # Conflicts: # src/renderer/components/ft-element-list/ft-element-list.vue # src/renderer/components/ft-prompt/ft-prompt.css # src/renderer/components/ft-toast/ft-toast.css # src/renderer/scss-partials/_ft-list-item.scss # src/renderer/views/Playlist/Playlist.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subscribed icon to comments
Pull Request Type
Related issue
Closes #1823
Description
Adds a freetube icon as suggested beside a comment author's username for whomever the current profile is subscribed to
Screenshots
Top shows what it would look like if the verified icon is to be added in the future. (if using fontawesome)
Testing
https://youtu.be/KgmV2GaN-J0
Subbing/unsubbing works fine, icon updates accordingly.
Changing profiles in a video also updates the icons accordingly.
Desktop
Additional context