Add external player support for Baka, Celluloid & Haruna #4067
Conversation
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
|
Waiting Baka to be tested first |
|
In addition to the testing in #3990 (comment), I've also spun up a Manjaro VM and Baka works as expected there. So I'm inclined to leave it in for now. |
|
leaving last review for @absidue |
|
Is it worth adding Baka, a player, that according to the comments on the issue, struggles to play YouTube videos and hasn't seen development in years, so is unlikely to get fixed? |
|
I'll leave that decision up to you. It technically works in that it will play streams fine, if used with a modern yt-dlp and mpv binary, whether that's supplied manually on Windows or provided automatically through your distro's package manager on Linux. It just doesn't do much more than that. Personally, I'd say it's abandoned at this point and I wouldn't have included it if not asked for in the request. |
Head branch was pushed to by a user without write access
trostboot
dismissed stale reviews from PikachuEXE and ChunkyProgrammer
via
7f75aad
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer and
PikachuEXE
github-actions
bot
removed
the
PR: waiting for review
* development: Bump webpack from 5.88.2 to 5.89.0 (FreeTubeApp#4168) Fix playlists not showing up on artist topic channels with the local API (FreeTubeApp#4129) Bump undici from 5.19.1 to 5.26.3 (FreeTubeApp#4173) Bump marked from 9.1.0 to 9.1.2 (FreeTubeApp#4171) Bump sass from 1.69.0 to 1.69.3 (FreeTubeApp#4169) Bump the eslint group with 2 updates (FreeTubeApp#4166) Bump the babel group with 2 updates (FreeTubeApp#4165) Truncate title of playlist in queue window (FreeTubeApp#4134) Wrap channel tabs as soon as there isn't enough screen space (FreeTubeApp#4139) Keep download folder path when changing to 'ask for download path' and back (FreeTubeApp#4101) Add external player support for Baka, Celluloid & Haruna (FreeTubeApp#4067) Fix error when clicking on the current quality in the DASH quality selector (FreeTubeApp#4130)
Add external player support for Baka, Celluloid & Haruna
Pull Request Type
Related issue
closes #3990
Description
Adds basic support for Baka & Haruna and extended support for Celluloid
Testing
Haruna and Celluloid have been fully tested, all options should work. Baka does not appear to be in active development anymore and requires replacing mpv and youtube-dl on Windows to even work, and it segfaults for me in Linux.
If someone can confirm it works for them, I'll leave it in, otherwise I'll remove it.
Desktop