Display currently watching viewer count on live streams #4206
Conversation
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
|
Cannot review until PR released? |
|
I thought GitHub would just queue up the review requests until it was marked ready for review, but I guess not, sorry. |
|
Should this PR be set to ready to review? |
absidue
force-pushed
the
live-watching-count
branch
from
ce04f99
to
6ae01cf
Compare
github-actions
bot
added
the
PR: waiting for review
|
Yes, I've rebased it now, so you can actually test it and marked it ready-for-review. |
There was a problem hiding this comment.
- When live chat is disabled by the creator u cant see the viewer count anymore but on YT u can
- Users can also hide the live chat in the distraction free settings and that also hides the viewer count
U could move the element next to the started streaming element this is how YT does it idk if it is a better UX though
|
We can't have it separate from the live chat because that view count comes from polling the live chat endpoints, I can move it in the UI, but I'll still have to hide it if the video doesn't have a live chat. We could ask YouTube.js to have duplicate code so we can poll it every 5 seconds even when the video doesn't have a live chat but that seems like quite an edge case. |
|
Ah ok, the only thing i maybe would like to see is the same as @jasonhenriquez suggestion about
Maybe to make it look nice we can reuse the same separators we use in the img below?
|
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
|
Updated the styling using @jasonhenriquez suggestion. |
ChunkyProgrammer
requested review from
kommunarr and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
removed
the
PR: waiting for review
* development: Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Kurdish (Central)) Translated using Weblate (Spanish) Translated using Weblate (Kurdish (Central)) Translated using Weblate (Kurdish) A new way to subscribe (FreeTubeApp#4238) Display more profiles on the profile drop-down list, v2 (fixed for low res, fixed linter) (FreeTubeApp#4359) Translated using Weblate (Estonian) Translated using Weblate (Serbian) Translated using Weblate (Arabic) Translated using Weblate (Chinese (Simplified)) Display currently watching viewer count on live streams (FreeTubeApp#4206) Translated using Weblate (Spanish) Translated using Weblate (Czech) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Italian) Fix block channel channel ID validation (FreeTubeApp#4366)
Display currently watching viewer count on live streams
Pull Request Type
Related issue
closes #4081
Description
Adds the currently the number of people currently watching the live stream to the live chat. It'll update about every 5 seconds similarly to YouTube. Respeccts the "Hide Video Views" setting.
While I know that visually the live chat view probably isn't the best place for this number, as it only works when the live chat is visible, I decided that placing in there would be less confusing to users (also keeps the code simpler as i don't have to move the value between 3 different components).
Screenshots
Testing
Open a live stream with a live chat and make sure the "Hide Video Views" setting is disabled.
e.g. https://youtu.be/jfKfPfyJRdk
Desktop