Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Multiple) Local Playlist (instead of saving video in one hidden list) #4234

Merged

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Oct 26, 2023

Pull Request Type

  • Feature Implementation

Related issue

Description

Instead of saving videos (in one hidden playlist) and displaying only that list
This PR makes it possible to manage multiple local playlists and adding videos to it
You can also import export

Tasks Left

  • Translation (already done but could have some entries missed)
  • Code Cleanup

Screenshots

Tooltip & toggle for exporting playlists as single favorites playlist

image

Testing

  • Playlist migration (from old version of FT)
  • Playlist import export (from old/new version of FT)
  • Playlist management
  • Video management in playlist (including adding video(s) to playlist)
  • I18n (not sure how to test this)
  • What else?

Tooltip & toggle for exporting playlists as single favorites playlist

  • Checkout this PR, add some playlists and videos, probably also removed the default playlists
  • Export playlists as usual (also as backup file for different tests
  • Export playlists with new toggle on
  • Remove all playlists
  • Switch back to development, import the export with new toggle on
  • Confirm all videos from all playlists are present

Additional context

Code based on branch https://github.com/FreeTubeApp/FreeTube/tree/playlists
See https://github.com/PikachuEXE/FreeTube/issues for issues reported before this PR created

Can discuss in PikachuEXE#49 if you have specific topic

…ing to hide playlist settings

Only those visible on video, remote playlist are updated
Mainly due to YT missing video thumbnail image got different aspect ratio 4/3
jasonhenriquez
jasonhenriquez previously approved these changes Dec 17, 2023
@PikachuEXE
Copy link
Collaborator Author

Download latest build if you want to
https://github.com/PikachuEXE/FreeTube/actions/workflows/build.yml?query=branch%3Afeature%2Fplaylist-2023-05

@ArthurKun21
Copy link

Hello

First off, thank you for the hard work for this feature.

I have the new build and stable build side by side

  1. I perform the search from the main playlist tab and wasn't able to find my videos in the default playlist that was created. It was being search just fine at the stable build.
  2. If possible also search option when inside the playlist.
  3. If also possible a sort option inside the playlist, so that the last item in the playlist would show up first. Would be helpful once starting the migration to the new playlist.
  4. the current button in add to playlist which you can copy the video into the new playlist, if possible could the move to the new playlist be added as well so that we don't have to delete the video after copying.

* development:
  Bump the babel group with 2 updates (FreeTubeApp#4466)
  Bump the eslint group with 4 updates (FreeTubeApp#4468)
  Bump @seald-io/nedb from 4.0.2 to 4.0.3 (FreeTubeApp#4469)
  Bump marked from 11.0.1 to 11.1.0 (FreeTubeApp#4470)
  Bump github/codeql-action from 2 to 3 (FreeTubeApp#4472)
  Only bundle the Swiper modules that we use (FreeTubeApp#4455)
@PikachuEXE
Copy link
Collaborator Author

Just fixed a bug found when I use the build myself: playlist link in watch page not having playlistType

I did a search in code and there should be no other places having link to a local user playlist

6647099 (#4234)

@absidue
Copy link
Member

absidue commented Jan 2, 2024

The "Remove Watched Videos" button is displayed inside of playlists, even when "Remember History" is disabled, is that intentional?

@efb4f5ff-1298-471a-8973-3d47447115dc

I think it is, disabling that feature applies only on future watched videos not previously watched videos

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 2, 2024
@FreeTubeBot FreeTubeBot merged commit c40b4a6 into FreeTubeApp:development Jan 3, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 3, 2024
@jasonhenriquez jasonhenriquez mentioned this pull request Jan 4, 2024
1 task
@shellheim
Copy link

Wow, finally. Never though I would see this get merged in my life. Thanks for the work @PikachuEXE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants