Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block channel by channel URL (with ID) #4347

Merged

Conversation

kommunarr
Copy link
Collaborator

Block channel by channel URL (with ID)

Pull Request Type

  • Feature Implementation

Related issue

#4346 (first part)

Description

Silently enables blocking channels by channel link with ID (i.e., input text like */:id). Silent because if we said you can put in channel IDs without implementing support for the other types of channel links, there will be inevitable confusion and uproar.

Testing

  • Input normal channel IDs and validate that it is working as usual
  • Input channel link with ID (e.g., https://www.youtube.com/channel/UCadtap8RYMNy8w4K9lXhzpQ, https://invidious.perennialte.ch/channel/UCc9EIXDG6nul3XXf79GhZDw) and validate that it is working

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.1

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 18, 2023 13:17
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 18, 2023
@FreeTubeBot FreeTubeBot merged commit 3fc2e54 into FreeTubeApp:development Nov 21, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 21, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 21, 2023
* development:
  Update to silently allow channel links (with IDs) (FreeTubeApp#4347)
  Add hide channel option directly to More Options menu (FreeTubeApp#4228)
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Spanish)
  Make landing page configurable (FreeTubeApp#4200)
  Bump @silvermine/videojs-quality-selector from 1.3.0 to 1.3.1 (FreeTubeApp#4362)
  Bump electron from 27.0.4 to 27.1.0 (FreeTubeApp#4363)
  Bump the eslint group with 1 update (FreeTubeApp#4360)
  Bump actions/github-script from 6 to 7 (FreeTubeApp#4361)
  add image to poll & updated quiz style (FreeTubeApp#4318)
  Move hideOutlines to the utils store instead of using provide/inject (FreeTubeApp#4246)
  Translated using Weblate (Kurdish (Central))
  Translated using Weblate (English (United Kingdom))
  Translated using Weblate (French)
  Translated using Weblate (German)
  Added translation using Weblate (Kurdish (Central))
  Translated using Weblate (Slovak)

# Conflicts:
#	src/renderer/components/ft-list-video/ft-list-video.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants