Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Nordic base theme #4542

Merged
merged 7 commits into from
Feb 3, 2024

Conversation

JonahFoster
Copy link
Contributor

@JonahFoster JonahFoster commented Jan 13, 2024

Added a Nordic base theme

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #4540

Description

Added a Nordic theme option in theme settings and properly added it to the localization file. Customized the theme in themes.css following the suggested hex codes in the issues.

Screenshots

Before (System Default, light blue accents)
Screenshot_2
After (Nordic, light blue accents)
Screenshot_1

Testing

Desktop

  • OS: Windows
  • OS Version: Windows 10 Version 10.0.19045 Build 19045
  • FreeTube version: v0.19.1 Beta

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 13, 2024 15:59
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 13, 2024
kommunarr
kommunarr previously approved these changes Jan 21, 2024
Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

suggestion (non-blocking): Create an #EEE color FreeTube icon and title used for this theme in an editor like GIMP, like is done with Dracula. The contrast (pictured below) is a bit jarring. However, given that we don't have this for the similar cases of the Dark or Black themes, I don't see this as an absolute necessity.

Screenshot_20240120_214310

@JonahFoster
Copy link
Contributor Author

This looks great!

suggestion (non-blocking): Create an #EEE color FreeTube icon and title used for this theme in an editor like GIMP, like is done with Dracula. The contrast (pictured below) is a bit jarring. However, given that we don't have this for the similar cases of the Dark or Black themes, I don't see this as an absolute necessity.

Screenshot_20240120_214310

Ironically I didn’t make a new one because I saw that Black didn’t have one, I can make a new icon and commit it soon

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 30, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc

I can make a new icon and commit it soon

If thats the case i'll hold off approving

auto-merge was automatically disabled January 30, 2024 18:56

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 30, 2024 18:56
@JonahFoster
Copy link
Contributor Author

I can make a new icon and commit it soon

If thats the case i'll hold off approving

Just added the icon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-merge was automatically disabled February 1, 2024 12:50

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 1, 2024 12:50
src/renderer/themes.css Outdated Show resolved Hide resolved
src/renderer/themes.css Outdated Show resolved Hide resolved
auto-merge was automatically disabled February 1, 2024 21:20

Head branch was pushed to by a user without write access

Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 1, 2024 21:21
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Feb 1, 2024
Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FreeTubeBot FreeTubeBot merged commit 0663a29 into FreeTubeApp:development Feb 3, 2024
6 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Nordic base theme
5 participants