Fix handling of video published date in video lists

[absidue]

Fix handling of video published date in video lists

Pull Request Type

• Bugfix
• Feature Implementation

Related issue

Fixes #4541 (not sure if GitHub automatically closes discussions with pull requests but I'm listing it here anyway)
Fixes #2579
Closes #3736

Description

This started as an investigation into #4541 (FreeTube showing published dates in German, despite the display language being set to English) and in the process of fixing that, I ended up solving #2579 and implementing #3736.

The issue with the translated published strings was because we were using the publishedText property in Invidious' API response, which it turns out is a translatable string on the Invidious side, so when an instance like invidious.nerdvpn.de decides to randomly return German translations for no apparent reason, FreeTube bugs out and shows that to the user. The solution to that is using the published property instead, which contains Invidious' parsing of the publishedText into a unix timestamp in milliseconds.

As I was switching to the published field for Invidious anyway, I decided I might as well do it for the local API too, that means parsing the relative date strings during the local API parsing, so that ft-list-video only has to deal with unix timestamps. Converting it back to a relative timestamp is then done in ft-list-video based on the current date and time. One major benefit of doing that, is that when we save videos in the subscription cache, they are no longer saved with 10 minutes ago, instead they have the unix timestamp, so instead of only being able to show 10 minutes ago when it is restored from the cache 3 hours later, it will now show 3 hours ago.
Please note that as these timestamps are calculated based on relative timestamps, they might not match up with YouTube's, as they have access to the absolute timestamp in their databases. However showing a potentially slightly off relative timestamp is a lot better than still showing 10 minutes ago 3 hours after the video was published.

The mark as watched invalid date issue was caused by us saving the text "10 minutes ago" in the watch history, but as we save the unix timestamp on the watch page, the code that read the date from the history was expecting a unix timestamp, which "10 mins ago" most certainly is not. The solution to that was quite easy now that the rest of the ft-list-video component was already using unix timestamps.

Testing

1. Test various video lists (e.g. subscriptions, search, trending) with both the local and Invidious API and make sure that published dates show up correctly.
2. Mark a video as watched from the subscription page (3 dots menu -> Mark as Watched) with the local or Invidious API without RSS and check the history tab to confirm that it shows an actual date and time instead of Invalid date
3. Refresh your subscriptions without RSS, wait a while and then come back later, switch to a different page (the timestamps don't update live while you are on the same page, as that would be quite expensive to do every second) and then back to the subscriptions page and it should show updated timestamps without you refreshing the subscriptions.

This pull request doesn't change how published dates are handled for community posts, but I will switch that to the published field in a follow up pull request, so we get the same updated timestamps when we restore it from the cache.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: latest nightly

[PikachuEXE]

Date format seems changed for some reason

Before this PR (history page)

This PR

[efb4f5ff-1298-471a-8973-3d47447115dc]

Seeing the same as Pika

Also

Something is wrong bc this podcast is live once a week on YT and you will see here that the published date for multiple streams is marked as 30 days ago

VirtualBoxVM_ucMWIJgmuK.mp4

[absidue]

I had based it on the existing formatting code, which seems to only switch to months when it's above 31 days and doesn't support weeks, so I'll need to change that.

[absidue]

@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc Those issues should be fixed now :).

[efb4f5ff-1298-471a-8973-3d47447115dc]

Marked watched date reflects date of vid being published when viewing it in History

VirtualBoxVM_RpmIppbh8C.mp4

Edit: Most popular tab has interesting publish dates

[absidue]

Marked watched date reflects date of vid being published when viewing it in History

That's the same as if you watch it on the watch page.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Wow im not sure i ever noticed that. To me that doesnt make sense but that is probably out of scope of this PR

[absidue]

Fixed now (Invidious gives all videos on the popular page the type shortVideo, even though they are clearly normal videos).

[PikachuEXE]

I still see date format change

[absidue]

It respects the users chosen locale now, so as you presumably selected en-US as your display language, you get month/day/year.