Add back author search in video playlist searching

[kommunarr]

Add back author search in video playlist searching

Pull Request Type

• Feature Implementation

Related issue

N/A (marked as bug in #4857)

Description

Reuses previous paradigm (the paradigm currently in place in History.js). This was the pre-existing behavior before the Playlist PR. See

FreeTube/src/renderer/views/UserPlaylists/UserPlaylists.js

Lines 98 to 103 in 5c8d49b

	const filteredQuery = this.favoritesPlaylist.videos.filter((video) => {
	if (typeof (video.title) !== 'string' || typeof (video.author) !== 'string') {
	return false
	} else {
	return video.title.toLowerCase().includes(lowerCaseQuery) || video.author.toLowerCase().includes(lowerCaseQuery)
	}

.

Testing

• Search for video title (variegate casing, should be insensitive)
• Search for author (variegate casing, should be insensitive)

Desktop

• OS: OpenSUSE
• OS Version: TW
• FreeTube version: Why do we even ask this one for PRs?

[absidue]

Instead of bailing out when either of them are missing it would be better to check them individually e.g. with this pseudo-code:

if has title and match in title
    return true

if has author and match in author
    return true

return false

[efb4f5ff-1298-471a-8973-3d47447115dc]

Probably going to suggest something controversial here.

I think i like to see a Filter on the main playlist page that enables Search by Author so i instantly know in what playlists the author is in in and if i click on that playlist that search shows me the same query as the one i just on the main playlist page. Just like how it works with the other filter

VirtualBoxVM_wBPwlbaZFQ.mp4

[kommunarr]

It sounds interesting, but I don't want to add it as a feature unless a user asks for it. I don't have a use case for that personally.

[PikachuEXE]

Users should be able to search for author in user playlists view too when Playlists with matching videos is on
Otherwise it's inconsistent since they can search for video title there now

Places to change: search if (this.doSearchPlaylistsWithMatchingVideos) {

[kommunarr]

My bad, I misread the suggestion as adding a new filter toggle for video author search specifically. Added now.

[efb4f5ff-1298-471a-8973-3d47447115dc]

My bad, I misread the suggestion as adding a new filter toggle for video author search specifically. Added now.

Well i actually did mean that but Pika suggestions is way better