Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup problems for some Linux platforms for some installs #5054

Conversation

jasonhenriquez
Copy link
Collaborator

@jasonhenriquez jasonhenriquez commented May 2, 2024

Fix startup problems for some Linux platforms for some installs

Pull Request Type

  • Bugfix

Related issue

None; Segmentation fault (core dumped) occurring for some Linux users post-Electron 30

Description

Co-created with @absidue

  • Fixes downloads for Wayland (not sure if any others) users using non-7z/portable Linux builds

Testing

Desktop

  • OS: OpenSUSE
  • OS Version: TW

Additional context

This does not work for 7z / portable downloads, which is going to be a major problem for those users going forward. The commit in this PR can be reverted once electron/electron#35630 is merged.

@jasonhenriquez jasonhenriquez marked this pull request as ready for review May 3, 2024 00:12
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 3, 2024 00:12
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 3, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Downloaded and installed freetube_0.20.0_amd64.rpm on Fedora 40 VM but application isnt opening :(

Edit: Ill try my Ubuntu VM

@efb4f5ff-1298-471a-8973-3d47447115dc

Downloaded and installed freetube_0.20.0_amd64.deb on my Ubuntu VM but also refused to open

@efb4f5ff-1298-471a-8973-3d47447115dc

Hmm did a sanity check and downloaded installers from our website and installed them. They also didnt open....

Installed the FT from flatpak and it was completely ok so im not sure what is happening on my end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it again a day later and it worked....

LGTM

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc dismissed their stale review May 5, 2024 12:06

Srry made a mistake. Installer from our website runs but this build still doesnt run for me

@jasonhenriquez
Copy link
Collaborator Author

Are you using a non- 7z/portable build? @efb4f5ff-1298-471a-8973-3d47447115dc

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Tried freetube_0.20.0_amd64.rpm and freetube_0.20.0_amd64.deb

Edit: you probably only saw my last comment, I left multiple :)

@jasonhenriquez
Copy link
Collaborator Author

Sorry about that! Could you show what error is occurring when you try to open it?

@efb4f5ff-1298-471a-8973-3d47447115dc

Im not getting any visual error. If i click on the application it doesnt start. If i run freetube in the terminal it acts like it ran FT but nothing happens. Any advice how i should capture an error?

@absidue
Copy link
Member

absidue commented May 5, 2024

@efb4f5ff-1298-471a-8973-3d47447115dc If you run it from the terminal you need to add the --ozone-platform-hint=auto flag yourself (this pull request adds when it gets launched through the UI, e.g. icon in the task bar).

@efb4f5ff-1298-471a-8973-3d47447115dc

Oh my bad. Added it but still doesnt do anything for me....
It just sits idle like this starring at me :(

VirtualBoxVM_boeKWt92Tl.mp4

auto-merge was automatically disabled May 11, 2024 13:05

Pull request was closed

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 11, 2024
@jasonhenriquez jasonhenriquez mentioned this pull request May 11, 2024
1 task
@jasonhenriquez
Copy link
Collaborator Author

Closing this in favor of temporarily reverting the Electron version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants