Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always have quick bookmark set #5058

Merged

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    000d5cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a0bf57 View commit details
    Browse the repository at this point in the history
  3. Import regular fontawesome icons for showing the bookmark

    The original plan: use the Quick Bookmark icons here for enabled/disabled sates. Problem: colors would be off if we used the same background color for the ft-list-item. Button would barely appear visible. Thereore, we should probably use the existing 'secondary' theme. Problem: the 'checked' icon then looks unrecognizable and instead generic. Solution: use 'unfilled'/regular icon version for disabled state and 'filled'/solid icon version for enabled state, specifically on the ft-playlist-info page.
    kommunarr committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e897254 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b59a6d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Update translation text

    Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
    Configuration menu
    Copy the full SHA
    ba0fb67 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Apply suggestions from code review

    Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
    kommunarr and absidue committed May 13, 2024
    Configuration menu
    Copy the full SHA
    27ab7e3 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    676b8e6 View commit details
    Browse the repository at this point in the history
  2. Co-authored code with @PikachuEXE allowing quick bookmark to be set o…

    …n ft-list-playlist item
    kommunarr committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a36c64f View commit details
    Browse the repository at this point in the history
  3. Update logic to use empty or latest played playlist as fallback target

    Also removes now unneeded on-removal logic.
    kommunarr committed May 14, 2024
    Configuration menu
    Copy the full SHA
    93ed9ab View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    cf460f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5026d80 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…

    …at/always-have-quick-bookmark
    kommunarr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    47a5702 View commit details
    Browse the repository at this point in the history
  4. Update to use @disabled-click event instead of showToast-specific beh…

    …avior
    
    The prior implementation was also leading into module loading errors.
    kommunarr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a5ccd53 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b3166ce View commit details
    Browse the repository at this point in the history
  6. Update casing for label

    kommunarr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    93b10ab View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    a81a9f2 View commit details
    Browse the repository at this point in the history