Fix hide/show channel in ft-list-video #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
May 21, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
It doesn't remove it per se, the distraction free settings just no longer fetches it for some reason, when the channel is hidden through the dropdown. I need to figure out why. |
absidue
added
PR: waiting for review
|
Fixed it. Turns out it was two issues, firstly it was only fetching the thumbnail if the channel name wasn't set, so I've made it check if the thumbnail URL is missing too and secondly it was randomly failing because it wasn't parsing the channel header correctly. |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
May 22, 2024
|
For Testing section (6) do you mean I also tested show channel item actually removes channel from |
kommunarr
previously approved these changes
May 23, 2024
kommunarr
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and themself
via
12e6cb3
kommunarr
force-pushed
the
fix-hide-channel
branch
from
12e6cb3
to
e239adc
Compare
|
Don't code at night (I pushed to the wrong branch because I mistyped my |
kommunarr
approved these changes
May 23, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 23, 2024
@PikachuEXE Yes |
PikachuEXE
approved these changes
May 23, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
May 26, 2024
* development: Fix channel sort values to show the values they are (FreeTubeApp#5162) Translated using Weblate (Russian) Translated using Weblate (French) Quick bookmark button RTL & hover fixes (FreeTubeApp#5157) Use addVideo instead of addVideos for quick bookmark button (FreeTubeApp#5168) Cache quick bookmark playlist to reduce the amount of lookups (FreeTubeApp#5169) Translated using Weblate (Arabic) Translated using Weblate (Indonesian) Fix hide/show channel in ft-list-video (FreeTubeApp#5149) # Conflicts: # src/renderer/components/ft-list-video/ft-list-video.js # src/renderer/components/watch-video-info/watch-video-info.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hide/show channel in ft-list-video
Pull Request Type
Related issue
Description
The
ft-list-videocomponent was never updated to the new (well not very new anymore) structure of the hidden channels. This pull request corrects that so that it now works as expected.Testing
(Adapted from the bug reproduction steps in the linked issue)
Hide ChannelHide ChannelDesktop