Play next/prev video after removing current video from the playlist #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
previously approved these changes
May 23, 2024
absidue
previously approved these changes
May 25, 2024
kommunarr
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
May 29, 2024
…al is zeroth & loop is enabled
|
Excellent catch John, we are very lucky to have someone with such great testing skills & discipline! |
kommunarr
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc,
PikachuEXE and
absidue
PikachuEXE
previously approved these changes
May 30, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
May 30, 2024
|
@efb4f5ff-1298-471a-8973-3d47447115dc Could you share what you did before this? From the logs, it seems like somehow a |
|
This is all i did VirtualBoxVM_pzRc1vEla3.mp4 |
|
Thanks @efb4f5ff-1298-471a-8973-3d47447115dc, fixed now. Here's one thing I added:
Here's one thing I gave up on adding:
|
kommunarr
force-pushed
the
feat/play-next-or-prev-from-deleted
branch
from
cd9d91b
to
9d71186
Compare
kommunarr
force-pushed
the
feat/play-next-or-prev-from-deleted
branch
from
9d71186
to
d00bc83
Compare
kommunarr
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
1 task
|
|
Thank you and great catches, I admittedly would never have caught these last two. I think it's all good now knock on wood |
|
Removed video spawns back in? VirtualBoxVM_U5A7sv2Y4J.mp4 |
|
Still looking into this one. I think I'm going to be fixing bugs with this PR until I die Edit: thankfully this was an obvious error from my part, now things seem good |
kommunarr
force-pushed
the
feat/play-next-or-prev-from-deleted
branch
from
379e62e
to
4f37130
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jun 4, 2024
absidue
reviewed
Jun 4, 2024
src/renderer/components/watch-video-playlist/watch-video-playlist.js
Outdated
Show resolved
Hide resolved
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 6, 2024
absidue
approved these changes
Jun 6, 2024
PikachuEXE
approved these changes
Jun 6, 2024
| @@ -232,6 +216,23 @@ export default defineComponent({ | |||
| } | |||
| }, | |||
| methods: { | |||
| findIndexOfCurrentVideoInPlaylist: function (playlist) { | |||
There was a problem hiding this comment.
nitpick: this should be videos / playlistItems
findIndexOfCurrentVideoInPlaylist is called with various source of video lists (with different sorting orders applied)
Comment on lines
+490
to
+491
| const isCurrentVideoInParsedPlaylist = this.findIndexOfCurrentVideoInPlaylist(playlist.videos) !== -1 | ||
| if (!isCurrentVideoInParsedPlaylist) { |
There was a problem hiding this comment.
Why use double negative here... (and below)
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Play next/prev video after removing current video from the playlist
Pull Request Type
Related issue
closes #4918
Description
When you delete the video that is shown as being currently watched in
watch-video-playlist, the video index will now visually appear to be the video prior to that one. if you delete that one, it carries on the video prior, and so forth. When the video autoplays or you clickPlay Next Videoin this state, it plays the video that is shown as the one after the current video. When you clickPlay Previous Videoin this state, it plays the video that is shown as the "current" video. (Edit 2024-05-31) If the current video cannot be found in the user playlist at all, e.g., removing it while watching it & reloading the page, the index becomes the 1st video in the playlist, preventing the glitchy "0/x videos" state from ever occurring. These are all existing behaviors of YT.Note that if you were to navigate back to the previous route for a deleted playlist entry through the
Backbutton, the current video index will be set to zero, as this feature is reset when you navigate to a new route. This pre-existing behavior is fine, and making this more "durable" is not worth the effort. Believe me, I've tried.Screenshots
Testing
watch-video-playlistupdate to the prior videoA. Test
Play Previous Videoplays the video with the same index as the video with the play iconB. Test
Play Next Videoand autoplay plays the video with index one higher than the video with the play iconwatch-video-playlistupdate to the prior video, then delete that one. See that the play icon then goes the video prior to that.A. (Optional) Repeat validations 1A and 1B in this state.
Desktop
Additional context