Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local API: Extract releases on auto-generated artist topic channels #5241

Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Jun 9, 2024

Local API: Extract releases on auto-generated artist topic channels

Pull Request Type

  • Feature Implementation

Related issue

#5201 (was actually about Invidious returning a HTTP 500 error when you request those channels but it also covered the albums and singles not showing up)

Description

I originally addressed this in #4129 but then YouTube redesigned the auto-generated artist topic channels before we did a release, so it never actually worked in a release version of FreeTube (which is why I made sure my pull request wasn't listed in the release notes), so I'm counting this as a feature implementation.
This pull request adds support for the new design and layout by displaying albums and singles in the releases tab on auto-generated artist topic channels. That seemed that most fitting tab to display them in, as that's where YouTube displays them when you visit the actual artist's channel (the user one and not the auto-generated one from YouTube Music).

As the small list of albums and singles displayed on the home tab, as the same as the first few in the view all popup, I decided to only extract from the popup but to fallback to the small list on the home tab in case extracting from the popup fails.

Screenshots

screenshot

Testing

  • Only has one page of releases, no load more button (Adele - Topic): https://www.youtube.com/channel/UCRw0x9_EfawqmgDI2IgQLLg
  • Has many pages of releases, test that loading more works (David Guetta - Topic): https://www.youtube.com/channel/UCh-4c1ZoBPNP1C8c-7iVvUQ
  • Normal user channel, just to make sure I didn't break it (YouTube): https://www.youtube.com/channel/UCBR8-60-B28hp2BmDPdntcQ

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: bf3304d

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 9, 2024 17:33
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 9, 2024
@FreeTubeBot FreeTubeBot merged commit d12abb8 into FreeTubeApp:development Jun 11, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 11, 2024
@absidue absidue deleted the artist-topic-channel-releases branch June 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants