Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes opening an external player on the watch page passes user playlist #5263

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Jun 13, 2024

Fixes opening an external player on the watch page passes user playlist

Pull Request Type

  • Bugfix

Related issue

#5188 (it's a discussion so the close keyword doesn't work)

Description

The code to open an external player in the watch-video-info component was checking this.inUserPlaylist to decide whether or not to pass the playlist information to the external player. Unfortunately though this.inUserPlaylist didn't exist, so it was passing playlist information to the external player. This pull request adds the missing inUserPlaylist property.

Screenshots

Before:
before

After:
after

Testing

  1. Add this code snippet to the top of the openInExternalPlayer in src/renderer/store/modules/utils.js
    console.log(payload)
    return
  2. Open FreeTube
  3. Set your external player to anything that isn't None (you don't actually have to have the player installed, because of the code snippet above)
  4. Watch a user playlist
  5. Click the open in external player button in the video info section
  6. Check the console and make sure the logged object doesn't contain any playlist information

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: da27eab

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 13, 2024 17:36
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 13, 2024
kommunarr
kommunarr previously approved these changes Jun 15, 2024
@absidue
Copy link
Member Author

absidue commented Jun 16, 2024

I've made the parameter required now.

@FreeTubeBot FreeTubeBot merged commit 73ed185 into FreeTubeApp:development Jun 16, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 16, 2024
@absidue absidue deleted the watch-external-player branch June 16, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants