Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch watch-video-(chapters, comments and description) from mounted to created #5344

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Jun 26, 2024

Switch watch-video-(chapters, comments and description) from mounted to created

Pull Request Type

  • Performance improvement

Related issue

https://github.com/orgs/FreeTubeApp/projects/4?pane=issue&itemId=68600886

Description

Switches watch-video-chapters, watch-video-comments and watch-video-description from created to mounted. See previous pull requests for the reasoning e.g. #5224

Testing

Check that the watch page still works.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.21.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 26, 2024 19:52
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 26, 2024
@FreeTubeBot FreeTubeBot merged commit e55c22a into FreeTubeApp:development Jun 27, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 27, 2024
@absidue absidue deleted the watch-created branch June 27, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants