Restore check for sectionListRender
#120
Conversation
Music channels still use the `gridRenderer`.
|
Could you fix the linter issue and it might be a good idea to replace shorts test with a test for one of the music channels :) |
I accidentally added the same condition twice to an `if else`. The result was that one of them would never execute.
Head branch was pushed to by a user without write access
The linter caught a conditional branch which I had accidentally made impossible to reach. |
Shorts don't display a visible lengthSeconds on channel pages at the moment, and I am unsure where this data could be pulled from without making additional calls.
|
If we are going to get rid of the shorts test, we could just adjust it to be more accurate to what is currently working. Looking at the other tests in the same file, most of them expect |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
ChunkyProgrammer
requested review from
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
Restore check for
sectionListRenderPull Request Type
Description
Music channels such as Infected Mushroom still use the
gridRendererto display their content, and as a result,yt-channel-infois returning no videos for these channels. This PR restores the check for thesectionListRendererin order to fix this issue with music channels.Screenshots
before:
after:
Testing
Here are some examples of channels which qualify as "music" channels if you want to check them:
Additional Information
It might be worth adding a test which checks a music channel in order to make sure the response is not empty.
This issue was originally brought up by someone on the freetube matrix channel.