This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Allow channel tags + channel urls #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const ajaxUrl = `https://www.youtube.com/user/${channelId}/${urlAppendix}` | ||
| async performChannelPageRequestWithFallbacks(channelId, urlAppendix) { | ||
| return await this.performChannelUrlRequest(channelId, urlAppendix).catch(async _ => { | ||
| return await this.performChannelTagRequest(channelId, urlAppendix).catch(async _ => { |
There was a problem hiding this comment.
made tag second as it seems like youtube will pe preferring these urls
ChunkyProgrammer
requested review from
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
approved these changes
Nov 16, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 21, 2022
absidue
approved these changes
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow channel tags to be passed + channel urls
Closes #129