Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share button #45

Open
Phyks opened this issue Sep 2, 2014 · 10 comments
Open

Share button #45

Phyks opened this issue Sep 2, 2014 · 10 comments
Assignees

Comments

@Phyks
Copy link
Member

Phyks commented Sep 2, 2014

Some ideas for the share button:

  • Share with Facebook / Twitter / Shaarli / Diaspora* / Status.net
  • If shared with Shaarli or Diaspora*, offer to import the tags
@tmos
Copy link
Contributor

tmos commented Sep 2, 2014

Actually, even facebook handle tags (twitter too, but it's obvious). So maybe we could set one option in settings for sharing or not the tags, and don't check/uncheck this every time ?

@Phyks
Copy link
Member Author

Phyks commented Sep 2, 2014

Yes, indeed ! My bad, I don't know Facebook at all, and barely know Twitter.

@Phyks
Copy link
Member Author

Phyks commented Sep 5, 2014

@tmos: I'm working on it. I thought about something like this (bottom of each article, remember to close Adblock) to show the share options (a small dropdown menu with icons for every supported service). What do you think ?

EDIT: Cf https://stackoverflow.com/questions/15857952/how-to-create-a-simple-social-sharing-dropdown-menu-in-css-html.

@Phyks
Copy link
Member Author

Phyks commented Sep 7, 2014

@tmos: Implemented it in the backend. You have a function get_sharing_options that you can call to retrieve the list of sharing options to all.

It returns an array of sharing options. Each sharing option is represented by the following array:

{"type": twitter | facebook | shaarli | diaspora, "url": URL}

where type is either twitter, facebook, shaarli or diaspora and url should be the base url of the sharing option API, meaning that {$sharing_option['url']}{$entry_url} should be the full URL to put on the button.

Feel free to ask if it's not clear.

@tmos
Copy link
Contributor

tmos commented Sep 7, 2014

I made a first try here :
b882938

But it doesn't work… Could you exlpain me my errors Dr RainTPL ?

Phyks added a commit that referenced this issue Sep 7, 2014
@Phyks
Copy link
Member Author

Phyks commented Sep 7, 2014

@tmos : I fixed the code for the template in bc62cd9.

Note that the link URL is not valid for now, due to a known bug in RainTPL rewriting (issue #44). We'll be fixed soon I think.

@tmos
Copy link
Contributor

tmos commented Sep 8, 2014

Thanks :)

@Phyks
Copy link
Member Author

Phyks commented Sep 8, 2014

yw

@Phyks Phyks assigned tmos and Phyks and unassigned tmos and Phyks Sep 9, 2014
@Phyks Phyks assigned eliemichel and unassigned tmos Sep 29, 2014
@eliemichel
Copy link
Member

I added a style to sharing links but I'm not fully convinced…
I will have a modal box spawn when no link has been set.

@tmos
Copy link
Contributor

tmos commented Oct 1, 2014

We may do as discused in #40 and let an html form already made in the modal box, and just add the article adress at the good places then show the modalbox at the click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants