Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallabag support #63

Merged
merged 8 commits into from
Sep 21, 2014
Merged

Add wallabag support #63

merged 8 commits into from
Sep 21, 2014

Conversation

qwertygc
Copy link
Contributor

Add wallabag support...

@eliemichel
Copy link
Member

I'm ok for merging, but wait for confirmation from @Phyks since he wrote the file that this PR modifies.

@@ -57,6 +57,6 @@
</article>
{/loop}

<p>{$nb_pages} pages</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un test est mieux ici, pour directement afficher l'accord correct. C'était sur ma TODO-list, tant qu'à modifier cette ligne, autant le faire.

@Phyks
Copy link
Member

Phyks commented Sep 18, 2014

@qwertygc : J'ai ajouté quelques annotations. Ok pour merger si corrigé.

@qwertygc
Copy link
Contributor Author

J'ai corrigé ces petits problèmes.

Phyks added a commit that referenced this pull request Sep 21, 2014
@Phyks Phyks merged commit 759efad into FreederTeam:master Sep 21, 2014
@Phyks
Copy link
Member

Phyks commented Sep 21, 2014

@qwertygc : Tu as un wallabag et tu as testé le code de partage ? J'ai mergé la PR, mais je n'ai pas de wallabag à disposition pour tester.

@qwertygc
Copy link
Contributor Author

J'ai testé le code dans d'autres outils, donc oui ca marche. Et sur freeder aussi, du moins chez moi.

On 21 septembre 2014 13:36:01 UTC+02:00, Lucas Verney notifications@github.com wrote:

@qwertygc : Tu as un wallabag et tu as testé le code de partage ? J'ai
mergé la PR, mais je n'ai pas de wallabag à disposition pour tester.


Reply to this email directly or view it on GitHub:
#63 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

@Phyks
Copy link
Member

Phyks commented Sep 21, 2014

Ok, nickel !

@qwertygc
Copy link
Contributor Author

Bon, j'ai corrigé, et y'avait un petit bug (c'est du quasi mystique car je me suis basé sur du booklmarklet. Mais bon, comme ça ca marche)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants