Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Update the strings for case sensitivity. Remove lines spacings in translatable strings. #702

Merged
merged 3 commits into from Apr 21, 2024

Conversation

bahiirwa
Copy link
Contributor

@bahiirwa bahiirwa commented Apr 9, 2024

  • Update the "Cancel" strings for case sensitivity.

@bahiirwa bahiirwa requested a review from swashata April 9, 2024 12:24
sprintf(
$this->get_text_inline(" The %s's %sdownload link%s, license key, and installation instructions have been sent to %s. If you can't find the email after 5 min, please check your spam box.", 'post-purchase-email-sent-message' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bahiirwa please revert this and other changes with the whitespace :) I know it is not ideal, but we will lose all community translations over this. Kindly just focus on fixing the cancel button text. Thanks.

Laurence Bahiirwa and others added 2 commits April 21, 2024 17:27
… that can be removed while translating.

This is the commit message #2:

[version-control] Revert breaking changes to string translation.
…ion function to populate the "Cancel" button of the subscription cancellation modal.
@swashata swashata force-pushed the feature/update-translation-strings branch from e08e82f to f32be34 Compare April 21, 2024 11:57
Copy link
Contributor

@swashata swashata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swashata swashata merged commit 9dafc31 into develop Apr 21, 2024
5 checks passed
@swashata swashata deleted the feature/update-translation-strings branch April 21, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants