Skip to content
This repository has been archived by the owner on May 28, 2022. It is now read-only.

Fix #571: Footer broken on RTD site #626

Merged
merged 1 commit into from
Oct 12, 2014
Merged

Fix #571: Footer broken on RTD site #626

merged 1 commit into from
Oct 12, 2014

Conversation

umcsdon
Copy link
Member

@umcsdon umcsdon commented Oct 10, 2014

Fix #571
Fix #596

Completed

  • Removed unused styling in docs/source/_templates/layout.html
  • Updated footer information
  • Changed theme: sphinx_rtd_theme (conf.py)

To-Do (later)

  • Add freeseer logo above search bar

@umcsdon
Copy link
Member Author

umcsdon commented Oct 10, 2014

@dideler Can you merge this one?

I have some problem with the logo part. Tried a few ways, none of them works.

Request:

  • Close 571 & 596
  • Open a logo issue

Thanks!

Edit: I found the pull request readthedocs/sphinx_rtd_theme#69 which solves the problem (not a good soulution).

@dideler
Copy link
Member

dideler commented Oct 10, 2014

I'm getting lots of warnings when trying to build the docs, see readthedocs/sphinx_rtd_theme/issues/142.

There's stuff in the sphinx_rtd_theme repo that we don't need and is causing warnings. I want to wait a bit to see if that issue makes any progress, and if not, I'll just delete the stuff we don't need (everything from the sphinx_rtd_theme repo except the theme directory).

Very soon we'll have a much better looking docs site, exciting!

@dideler
Copy link
Member

dideler commented Oct 12, 2014

Deleting the stuff didn't cause any problems and cleaned up the build. I also removed the default footer.

You can preview here http://freeseer.readthedocs.org/en/umcsdon-571-footer-fix/

Going to merge it later today.

@dideler dideler merged commit 78be2d1 into Freeseer:master Oct 12, 2014
@dideler
Copy link
Member

dideler commented Oct 12, 2014

Thanks @umcsdon!

@umcsdon umcsdon deleted the 571-footer-fix branch October 12, 2014 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch docs to bootstrap theme? Footer broken on RTD site
2 participants